-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 1926 gridstat openmp #1977
Merged
Merged
Changes from 4 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
ed6934b
Feature 1926. Introduce OpenMP in GridStat.
mo-mglover 86c1a50
Feature 1926. Add MET_OPENMP flag to automake setup.
mo-mglover b3a063a
Feature 1926. Indentation tweaks.
mo-mglover e0257c6
Feature 1926. Revert temporary C++17 temporary file code tweak.
mo-mglover 7d81d41
Feature 1926. Add _OPENMP ifdef for omp.h.
mo-mglover 3ff12fe
Feature 1926. Revert tweak to CXX optimisation level with MET_DEVELOP…
mo-mglover 9a045e0
Per #1926, switch the OpenMP configuration option from being like MET…
JohnHalleyGotway 4c176c4
Per #1926, just like --enable-grib2 and --enable-python, add a test p…
JohnHalleyGotway 7043995
Feature #1926: Ensure OpenMP flag is passed to the linker. Revert to …
mo-mglover 81c98b9
Feature #1926. Write thread count via logging, not cout.
mo-mglover 1abb2be
Feature #1926: Add note about --enable-openmp in installation.rst
mo-mglover d6969c6
Per #1926, adding a call to Grid-Stat to run on 2 threads. This shoul…
JohnHalleyGotway 2b37a69
Per #1926, updating GridStatConfig_rtma to switch width = 1 to 3. Thi…
JohnHalleyGotway 4b2982f
Per #1926, tweak the openmp log message slightly.
JohnHalleyGotway 3c1a5db
Per #1926, switch from manual --enable-openmp support in autoconf to …
JohnHalleyGotway b595de4
Per #1926, after switching to the AC_OPENMP() macro, these changes to…
JohnHalleyGotway 359d823
Merge branch 'develop' into feature_1926_gridstat_openmp
JohnHalleyGotway ecaa653
Per #1926, since openmp support will now be compiled by default, swit…
JohnHalleyGotway 9594505
Feature #1926. Use `default(none)` to force explicit `private` or `s…
mo-mglover e8d928b
Feature #1926: Default to single thread if OMP_NUM_THREADS is left un…
mo-mglover dd35aa4
Feature #1926: Add OpenMP initialisation to other tools calling fract…
mo-mglover e0d7840
Update met/src/basic/vx_util/handle_openmp.cc
mo-mglover 78e4354
Update met/src/basic/vx_util/Makefile.am
mo-mglover b2a6c1e
Feature #1926: Lengthen OMP_NUM_THREADS debug message, plus user guid…
mo-mglover f39313d
Set up the Runtime Environment Variables Section and started adding i…
63b1fce
Updated documenation and fixed typos
3e89e56
removed openmp.rst in favor of having the information contained in a …
83688f5
Fixed typo
d73d537
Merge branch 'develop' into feature_1926_gridstat_openmp
JohnHalleyGotway 821ca68
Merge branch 'develop' into feature_1926_gridstat_openmp
JohnHalleyGotway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this change intentional... changing ${CXXFLAGS=""} to ${CXXFLAGS_OPT="-03"}?
I believe that when in "development" mode, we want to disable optimization for easier debugging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot! No, it wasn't intentional. Will put that right and push up the correction.