Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #1977, #2001, #2005, #2006, #2007, and #2012. #2016

Merged
merged 54 commits into from
Jan 16, 2022

Commits on Oct 26, 2021

  1. Per #1906, modify code to pass entire path to make_temp_file_name ins…

    …tead of only the filename so that the function can tell whether or not the file exists. (#1952)
    
    Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
    jprestop and Julie Prestopnik authored Oct 26, 2021
    Configuration menu
    Copy the full SHA
    9437447 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Feature 1761 percent thresh (#1956)

    * Per issue #1761 in set_perc() adding code to get FBIAS numeric value, like 1.0 or 0.9, etc. SL
    
    * Per issue #1761: in set_perc(), modified actual percentile calculation at end to use the extracted FBIAS numeric value (float). SL
    
    * Per issue #1761: modified the check on the perc_thresh_freq_bias, just has to be > 0 now. SL
    
    * Per issue #1761: cleaned up code in set_perc(). SL
    
    * Per #1761, updates to Simple_Node::set_perc() to handle variable frequency bias amounts.
    Changes include:
    - Reverting the formatting of this back to how it originally was in the develop branch. In general, just match the formatting of the existing file, so as the minimize the number of difference lines.
    - Add logic to adjust the percentile to be found based on the requested FBIAS value. Multiplying or dividing the percentile by the FBIAS value depends on the inequality type and whether we're bias adjusting the forecast or observation data.
    - Adjust the log messages slightly.
    
    Please be aware that I'm not totally confident in these changes. They warrant much more testing. This logic is very, very confusing.
    
    * Per #1761, call compute_percentile() when double-checking the percentile values.
    
    * Per #1761, remove unused variable.
    
    * Per #1761, add warning for percentiles > 100.
    
    * Per #1761. In set_perc(), after testing cleaned up code. SL
    
    * Per issue #1761: adding new config file for testing dynamic FBIAS values. SL
    
    * Per issue #1761: added new unit test for dynamic FBIAS values when running grid_stat. SL
    
    * Per issue #1761, modified FBIAS section to indicated that the user can use dynamic values that are not 1.0. SL
    
    * Update met/docs/Users_Guide/config_options.rst
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update met/docs/Users_Guide/config_options.rst
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update met/docs/Users_Guide/config_options.rst
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update test/config/GridStatConfig_fbias_perc_thresh
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update test/config/GridStatConfig_fbias_perc_thresh
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update test/config/GridStatConfig_fbias_perc_thresh
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Update test/config/GridStatConfig_fbias_perc_thresh
    
    Co-authored-by: johnhg <johnhg@ucar.edu>
    
    * Per issue #1761, set nc_pairs_flag = FALSE. SL
    
    Co-authored-by: Seth Linden <linden@kiowa.rap.ucar.edu>
    Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
    3 people authored Nov 3, 2021
    Configuration menu
    Copy the full SHA
    8c446ff View commit details
    Browse the repository at this point in the history
  2. Feature 1905 ens_ctrl (#1955)

    Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
    JohnHalleyGotway and j-opatz authored Nov 3, 2021
    Configuration menu
    Copy the full SHA
    d60924c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3b13ce1 View commit details
    Browse the repository at this point in the history
  4. Per #1905, committing a hotfix directly to the develop branch. Revert…

    …ing the logic for computing the ensemble range back to what it was previously. The new version produced very slight differences in the 6-th or 7-th decimal place when compared to previous results. There's not good reason for these changes which were caused by the order of operations in casting from doubles to floats. Reverting back to the old logic prevents diffs for anyone else downstream and is the prudent choice.
    JohnHalleyGotway committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    5131042 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Configuration menu
    Copy the full SHA
    4ff28d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Feature 1949 cf netcdf documentaton (#1951)

    * #1949 Added CF compliant NetCDF into data IO
    
    * #1949 Added commas
    
    * #1948 Some corrections for typo and added the links for CF attributes
    
    * #1948 Added Performance with NetCDF input data
    
    * #1949 Corrected tyoe and applied Juloie's suggestions
    
    Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
    hsoh-u and Howard Soh authored Nov 15, 2021
    Configuration menu
    Copy the full SHA
    aee6269 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    867360f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    0990061 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1663bb6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    13996c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Configuration menu
    Copy the full SHA
    dae9db7 View commit details
    Browse the repository at this point in the history
  2. Hotfix for the develop branch to get met-10.1.0-beta4 compiling on WC…

    …OSS. The intel compiler does not allow adjacent >> characters when defining maps.
    JohnHalleyGotway committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    9bd9946 View commit details
    Browse the repository at this point in the history
  3. Updating the beta4 release date from 11/16 to 11/17 since the beta4 r…

    …elease needs to be recreated.
    JohnHalleyGotway committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    e0b659d View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Configuration menu
    Copy the full SHA
    817d9db View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Configuration menu
    Copy the full SHA
    4e28ae7 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2021

  1. Configuration menu
    Copy the full SHA
    6d16e23 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2021

  1. #1936 Excludes precip3hr, precip6hr, precip12hr, and precip10min from…

    … required variables for MESONET
    Howard Soh committed Nov 29, 2021
    Configuration menu
    Copy the full SHA
    39a5233 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Configuration menu
    Copy the full SHA
    c9434e8 View commit details
    Browse the repository at this point in the history
  2. Per #1985, VERY minor change to fix alignment of titles in Point-Stat…

    …... updating the develop branch.
    JohnHalleyGotway committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    84f8c7f View commit details
    Browse the repository at this point in the history
  3. #1936 Added an unit test for newer MESONET file

    Howard Soh committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    d35190e View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2021

  1. Merge pull request #1984 from dtcenter/feature_1936_madis_nc2

    Bugfix 1936 develop madis2nc
    hsoh-u authored Dec 2, 2021
    Configuration menu
    Copy the full SHA
    f81d250 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2021

  1. Configuration menu
    Copy the full SHA
    8c29f09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b93f4ea View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    49fb555 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2022

  1. Configuration menu
    Copy the full SHA
    e900334 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c981f4 View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2022

  1. Configuration menu
    Copy the full SHA
    0273cf1 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. #1965 Processed with the raw variable names and update them when the …

    …output is saved.
    Howard Soh committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    ab1199b View commit details
    Browse the repository at this point in the history
  2. #1965 Added unit test ioda2nc_same_input

    Howard Soh committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    d5cc7b1 View commit details
    Browse the repository at this point in the history
  3. #1965 Processed with the raw variable names and update them when the …

    …output is saved.
    Howard Soh committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    e48c5ff View commit details
    Browse the repository at this point in the history
  4. #1965 Added unit test ioda2nc_same_input

    Howard Soh committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    5617aa2 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2022

  1. #1965 initialize var_idx

    hsoh-u authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    ee76143 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2006 from dtcenter/feature_1965_ioda2nc_same_input

    Feature 1965 ioda2nc same input
    hsoh-u authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    1e97085 View commit details
    Browse the repository at this point in the history
  3. Update the development environment for seneca to add /usr/local/nco/b…

    …in and /usr/local/netcdf/bin to the path. Also define MET_TEST_RSCRIPT to point to a new enough version of RSCRIPT that has the ncdf4 package 1.17 or later.
    John Halley Gotway committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    acbb7b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    717dd17 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    58988bf View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    5632c5c View commit details
    Browse the repository at this point in the history
  7. Fixup the Rscript diffing logic to support running the nightly build …

    …on seneca. The problem here is that the ncdiff -x -v command line options that worked in version 4.7.0 NO LONGER work in 4.9.2. Added a check to skip over the time_bounds variable when processing the ncdiff output.
    JohnHalleyGotway committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    b267883 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d7eb8e4 View commit details
    Browse the repository at this point in the history
  9. No real changes here. Just formatting

    MET Tools Test Account committed Jan 12, 2022
    Configuration menu
    Copy the full SHA
    96536f5 View commit details
    Browse the repository at this point in the history
  10. Feature 1974 message_type_group_map (#1999)

    Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
    Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
    3 people authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    fa41760 View commit details
    Browse the repository at this point in the history
  11. Feature 1996 uninitialized variables (#2004)

    Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
    Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
    3 people authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    551f92b View commit details
    Browse the repository at this point in the history
  12. Feature 1695 ensemble single file (gen_ens_prod) (#2001)

    Co-authored-by: johnhg <johnhg@ucar.edu>
    georgemccabe and JohnHalleyGotway authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    dbc7d10 View commit details
    Browse the repository at this point in the history
  13. Feature 1965 NB faile with time summary by ioda2nc (#2008)

    Co-authored-by: Howard Soh <hsoh@kiowa.rap.ucar.edu>
    hsoh-u and Howard Soh authored Jan 12, 2022
    Configuration menu
    Copy the full SHA
    be7910e View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2022

  1. Configuration menu
    Copy the full SHA
    1e13dea View commit details
    Browse the repository at this point in the history
  2. More changes to test_util.R to account for differences between 4.7.0 …

    …and 4.9.2 of ncdiff. The earlier version reported 0 diffs for the time_bounds, lat, lon, latitude, and longitude variables while the newer version reports their raw values. Simply ignore these variables for now. This isn't a great solution but when we reimplement this testing logic in python, we can address this issue then.
    JohnHalleyGotway committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    37f4f32 View commit details
    Browse the repository at this point in the history
  3. Fix merge conflict

    JohnHalleyGotway committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    36761b6 View commit details
    Browse the repository at this point in the history
  4. Feature 1926 gridstat openmp (#1977)

    Co-authored-by: johnhg <johnhg@ucar.edu>
    Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
    Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
    3 people authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    de81526 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. feature 1695 ensemble single file (ensemble_stat) (#2007)

    Co-authored-by: johnhg <johnhg@ucar.edu>
    georgemccabe and JohnHalleyGotway authored Jan 14, 2022
    Configuration menu
    Copy the full SHA
    e96a211 View commit details
    Browse the repository at this point in the history
  2. Committing directly to the develop branch. Removing many, many instan…

    …ces of MET_BUILD_BASE and a couple instances of MET_BASE from the examples listed in Appendix A. The inconsistent use of these variables will only cause confusion. Removing them will help avoid that confusion. Big picture... MET_BASE defines the installed 'share/met' directory. It can be used to reference the location of map or polyline files. MET_BUILD_BASE is only used in the context of the test scripts. There, it's defined as the top-level source code directory in which the code was compiled. Its used to reference the location of sample data files or Rscript included in the tarball. I left a couple references to these variables in Appendix A where thier use is not confusing. But I removed all instances which are used to the define the location of the 'bin' directory. Instead, let's just assume the MET binaries are already in their path... or the user knows where to find them.
    JohnHalleyGotway committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    032456b View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. Configuration menu
    Copy the full SHA
    ee4a3a4 View commit details
    Browse the repository at this point in the history
  2. feature 1695 fix issues with ensemble changes (#2012)

    Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
    Co-authored-by: John Halley Gotway <johnhg@kiowa.rap.ucar.edu>
    3 people authored Jan 15, 2022
    Configuration menu
    Copy the full SHA
    18ccf3a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    634806e View commit details
    Browse the repository at this point in the history