Bugfix #2118 main_v10.1 grib1_rotll #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort for GRIB1 grid template 10 for rotated lat/lon grids. However this support may not be sufficient. - It works for the sample COSMO GRIB1 data file we have for testing (lfff03080000). - However, it basically just treats the rotated lat/lon grid as if it were not rotated. - The south pole is hard-coded to (lat, lon) = (-90, 0). - The rotation is hard-coded to 0. It is not clear how non-default values them would even be encoded in the GDS section. Before merging these changes, recommend finding or generating additional GRIB1 files on a rotated lat/lon grid for additional development and testing.
…rotated lat/lon grids in GRIB1. https://apps.ecmwf.int/codes/grib/format/grib1/grids/10/ These changes update the MET code to parse location of the south pole and auxiliary rotation. I double-checked in wgrib and see the exact same processing for rotated lat/lon GRIB1 files. So I'm confident in the approach. While it would be preferable to have additional sample data for testing, it's no longer a requirement for this bugfix.
20 tasks
15 tasks
…to main_vX.Y for a pull request into a main_vX.Y branch. Set the input data version to X.Y for PR into main_vX.Y, push into main_vX.Y or main_vX.Y-ref.
jprestop
added a commit
that referenced
this pull request
May 19, 2022
* added logic to manually trigger a workflow via the GitHub… (#2107) * Bugfix #2102 main_v10.1 initialize modified_hdr_typ (#2108) * Bugfix #2115 main_v10.1 Rotated LatLon (#2116) * Per #2123, added debug code to make this error that was unrepoducible, reproducible on seneca. Just initialize the newly allocated time_values array with values of -10. PLEASE REMOVE THAT TEST CODE PRIOR TO SUBMITTING A PR TO FIX THIS ISSUE. * #2123 Initialize ValidTime if afile to read time bvariable * #2123 Support int64 data type * #2123 Support int64 data type * Bugfix #2118 main_v10.1 grib1_rotll (#2129) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * Bugfix #2106 main_v10.1 gcc (#2134) * Feature 2141 v10.1.1 (#2144) * Add testing and docs badges. * #14 Using literal instead of numbers and make sure no overflow * #14 Using literal instead of numbers * #14 Added tmp_buf_size * #14 Define n_kw_infos first * #14 Using literal instead of numbers * Bugfix #2148 main_v10.1 misses (#2149) Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> * dtcenter/METplus-Internal#14 formatting code * Feature 2162 v10.1.2 (#2163) * Per #2162, update versions and notes for the 10.1.2 bugfix release * Per #2162, update versions and notes for the 10.1.2 bugfix release * Per #2162, fixing syntax error * Add "METplus-Internal" before the issue number for clarity Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com> Co-authored-by: johnhg <johnhg@ucar.edu> Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: hsoh-u <hsoh@ucar.edu> Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Ran plot_data_plane and regrid_data_plane as described in this issue comment to confirm that MET now handles this data.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review code changes. For the corresponding PR for develop, I'll add a new unit test that exercises this updated functionality.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
I made no changes to the docs. As of Enhance support for rotated latlon grids and update related documentation. #1574, the user's guide already claims that MET supports rotated lat/lon grids. It just that the support for GRIB1 files was missing.
Do these changes include sufficient testing updates? [No]
I made no test updates for main_v10.1 but will make them for the develop branch.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Friday 4/8/22].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes