Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 2162 v10.1.2 #2163

Merged
merged 4 commits into from
May 16, 2022
Merged

Feature 2162 v10.1.2 #2163

merged 4 commits into from
May 16, 2022

Conversation

jprestop
Copy link
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Nothing.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review the release notes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [No]

None needed

  • Will this PR result in changes to the test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    Updates the MET version number from 10.1.1 to 10.1.2.

  • Please complete this pull request review by [05/16/22].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Linked issues with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the MET 10.1.2 (bugfix) milestone May 16, 2022
@jprestop jprestop linked an issue May 16, 2022 that may be closed by this pull request
Create the MET v10.1.2 bugfix release #2162
Closed
21 tasks
JohnHalleyGotway
JohnHalleyGotway approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine to me. I made a proposed change to include METplus-Internal in the link name of the release notes. Assuming you make that change, or something similar, I approve.

@jprestop @JohnHalleyGotway
Add "METplus-Internal" before the issue number for clarity
2a27d8e 
Co-authored-by: johnhg <johnhg@ucar.edu>
@jprestop
Copy link
Collaborator Author

jprestop commented May 16, 2022 •
edited
Loading

@JohnHalleyGotway Thanks for the great suggestion (which I committed) and the review/approval!

@jprestop jprestop merged commit 1558222 into main_v10.1 May 16, 2022
@jprestop jprestop deleted the feature_2162_v10.1.2 branch May 16, 2022 20:48
@jprestop jprestop mentioned this pull request May 17, 2022
Merged
jprestop added a commit that referenced this pull request May 19, 2022
@jprestop @georgemccabe
@JohnHalleyGotway @hsoh-u
Update main_v10.1-ref after #2163 (#2164)
d0c66b8 
* added logic to manually trigger a workflow via the GitHub… (#2107)

* Bugfix #2102 main_v10.1 initialize modified_hdr_typ (#2108)

* Bugfix #2115 main_v10.1 Rotated LatLon (#2116)

* Per #2123, added debug code to make this error that was unrepoducible, reproducible on seneca. Just initialize the newly allocated time_values array with values of -10. PLEASE REMOVE THAT TEST CODE PRIOR TO SUBMITTING A PR TO FIX THIS ISSUE.

* #2123 Initialize ValidTime if afile to read time bvariable

* #2123 Support int64 data type

* #2123 Support int64 data type

* Bugfix #2118 main_v10.1 grib1_rotll (#2129)

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

* Bugfix #2106 main_v10.1 gcc (#2134)

* Feature 2141 v10.1.1 (#2144)

* Add testing and docs badges.

* #14 Using literal instead of numbers and make sure no overflow

* #14 Using literal instead of numbers

* #14 Added tmp_buf_size

* #14 Define n_kw_infos first

* #14 Using literal instead of numbers

* Bugfix #2148 main_v10.1 misses (#2149)

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>

* dtcenter/METplus-Internal#14 formatting code

* Feature 2162 v10.1.2 (#2163)

* Per #2162, update versions and notes for the 10.1.2 bugfix release

* Per #2162, update versions and notes for the 10.1.2 bugfix release

* Per #2162, fixing syntax error

* Add "METplus-Internal" before the issue number for clarity

Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Co-authored-by: johnhg <johnhg@ucar.edu>

Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: johnhg <johnhg@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: Julie Prestopnik <jpresto@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnHalleyGotway JohnHalleyGotway JohnHalleyGotway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Coordinated METplus-4.1 Support
Status: Done
Milestone
MET 10.1.2 (bugfix)
Development

Successfully merging this pull request may close these issues.

Create the MET v10.1.2 bugfix release
2 participants
@jprestop @JohnHalleyGotway