Feature #2036 rename

[JohnHalleyGotway]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Confirmed that make install test runs. Will see what diffs, if any, are flagged in the GHA run.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

  • @KathrynNewman please quickly review the doc changes.
  • @sethlinden please review the code changes.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  
  Changes the names and order of the 5 new columns in the TCMPR line type.

• Please complete this pull request review by [Tues 11/15/22].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[KathrynNewman]

doc updates correctly reflect changes to the consensus column names.

[JohnHalleyGotway]

I inspected the differences flagged in this GHA run and found that differences were flagged in a single file:

file1: /data/output/met_test_truth/tc_pairs/al132020_CONSENSUS.tcst
ERROR: found   226 differences in row type TCST_TCMPR   column TRACK_SPREAD  - max abs: 165.259 
ERROR: found   226 differences in row type TCST_TCMPR   column TRACK_STDEV   - max abs: 165.259 
ERROR: failed tests for TCST_TCMPR: num

As expected, the differences occur only in the consensus output lines (i.e. IVCN_CONS, UEMN_CONS, and so on). And the differences are just swapping the order of values in 2 columns.

So the GHA run revealed no unexpected diffs.

[sethlinden]

I reviewed all the code changes (and header changes). I can see that the fields: DIST_MEAN, MSLP_SPREAD, MAX_WIND_SPREAD changed to: TRACK_STDEV MSLP_STDEV MAX_WIND_STDEV. All the changes are related to this and look good.