Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance TC-Pairs consensus logic to compute the spread of the location, wind speed, and pressure. #2036

Closed
8 of 25 tasks
JohnHalleyGotway opened this issue Feb 2, 2022 · 24 comments · Fixed by #2301 or #2346
Closed
8 of 25 tasks
Assignees
Labels
MET: Tropical Cyclone Tools priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Feb 2, 2022

Describe the Enhancement

This enhancement request initially arose via METplus discussions in dtcenter/METplus#1341.

The METplus team met with NOAA/EMC on 2/2/2022 to discuss this issue and this GitHub issue is the result. Here are the steps:

  • Enhance the consensus derivation logic in TC-Pairs to also compute the location spread and standard deviation of the wind speed and pressure values.
    • Compute the location spread as the mean of the great circle distance from the consensus location to the location of each of the members.
    • Compute the standard deviation of wind speeds and pressure values as you normally would.
  • After these are computed, need to decide where/how to write these 3 additional values to the output.
    • One option to consider is adding 3 new columns to the end of the existing TCMPR line type. That wouldn't require many changes to the TC-Stat and the METdatadb load logic updates would be pretty easy. One downside is that the mean location and location spread would be very far from eachother in the output line. And that solution may conflict with the solution for Enhance TC-Pairs to read hurricane model diagnostic files (e.g. SHIPS) and TC-Stat to filter the new data #392.
    • Another option to consider is defining a new version of the TCMPR line type (perhaps "TCMPRCON" or something?) that is the same as the existing TCMPR line type, but with 3 extra columns added internally (not at the end). After the average location, speed, and pressure, we'd report the corresponding spread values. The downside is extra documentation and testing, upgrading TC-Stat to handle this, and upgrading METdata/METviewer to handle it. You'd often want to visualize TCMPR data from constituent models on the same plot at the TCMPRCON data. That may be difficult if they're stored in different line types.

Please see attached slides from the 2/2/2022 meeting:
J.Peng_discussion_20220202_new.pdf

Time Estimate

Estimate the amount of work required here.

Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

27703542

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing requestor: NOAA/EMC NOAA Environmental Modeling Center priority: high alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone MET: Tropical Cyclone Tools labels Feb 2, 2022
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.0.0 milestone Feb 2, 2022
@JohnHalleyGotway JohnHalleyGotway removed the alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle label Feb 8, 2022
@JohnHalleyGotway JohnHalleyGotway added priority: high High Priority and removed priority: high labels May 9, 2022
@JohnHalleyGotway
Copy link
Collaborator Author

JohnHalleyGotway commented Sep 7, 2022

Mentioned in the gap analysis for EVS version 1.0 on 9/7/22.
@JiayiPeng-NOAA should be added as an assignee on this issue.

@JiayiPeng-NOAA
Copy link

JiayiPeng-NOAA commented Oct 10, 2022 via email

@sethlinden
Copy link
Contributor

@JiayiPeng-NOAA sounds good. I think we may already be producing some of that output for the "consensus" model (TRACK_MEAN (LAT_MEAN; LON_MEAN), MSLP_MEAN, MAX_WIND_MEAN). But if we are not, I can certainly add those variables. I will also add output for NUM_MEMBERS. Thanks!

@JiayiPeng-NOAA
Copy link

JiayiPeng-NOAA commented Oct 11, 2022 via email

sethlinden pushed a commit that referenced this issue Oct 11, 2022
…orked compute_gc_dist_stdev() to compute track-spread and dist-mean. Re-organized. Cleaned up. SL ci-skip-all
sethlinden pushed a commit that referenced this issue Oct 11, 2022
…S TRACK_SPREAD DIST_MEAN MSLP_SPREAD MAX_WIND_SPREAD. SL ci-skip-all
sethlinden pushed a commit that referenced this issue Oct 11, 2022
…S TRACK_SPREAD DIST_MEAN MSLP_SPREAD MAX_WIND_SPREAD. SL ci-skip-all
sethlinden pushed a commit that referenced this issue Oct 12, 2022
…e type: NUM_MEMBERS, TRACK_SPREAD, DIST_MEAN, MSLP_SPREAD, MAX_WIND_SPREAD. Also updated some wording for the consensus section related to this. SL
sethlinden pushed a commit that referenced this issue Oct 12, 2022
sethlinden pushed a commit that referenced this issue Oct 12, 2022
…new consensus variables into the track-point object. SL ci-skip-all
JohnHalleyGotway added a commit that referenced this issue Oct 12, 2022
…ter which points the bdeck after the loop. Also update with newly generated Makefile.in files from seneca.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Oct 13, 2022 that will close this issue
15 tasks
JohnHalleyGotway added a commit that referenced this issue Oct 16, 2022
@JohnHalleyGotway JohnHalleyGotway changed the title Enhance the TC-Pairs consensus logic to compute the spread of the location, wind speed, and pressure. Enhance TC-Pairs consensus logic to compute the spread of the location, wind speed, and pressure. Oct 30, 2022
@JohnHalleyGotway
Copy link
Collaborator Author

JohnHalleyGotway commented Nov 14, 2022

Received feedback from @JiayiPeng-NOAA on 11/14/2022 recommending that we rename the 5 new TCMPR output columns as follows. Note that I swapped the order of TRACK_SPREAD and TRACK_STDEV below to group all the STDEV columns together:

NUM_MEMBERS, TRACK_SPREAD, TRACK_STDEV, MSLP_STDEV, MAX_WIND_STDEV

I confirmed and approved these changes with @KathrynNewman.

Reopening this issue to handle this renaming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MET: Tropical Cyclone Tools priority: high High Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants