-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix 2578 rotated latlon main v11.1 #2595
Conversation
@hsoh-u I just wanted to let you know that I see that you assigned this to me for review. I see that one of the tests is failing, likely due to space issues that we talked about at the MET meeting. I have a PR in to try to resolve those issues. Then, we can re-run these tests and see if they pass. I'd feel more comfortable approving this PR after showing that all tests pass. |
…_rotated_latlon_main_v11.1
…ated_latlon_main_v11.1
…center/MET into bugfix_2578_rotated_latlon_main_v11.1
Sorry to post here again, but I saw the GitHub generated comment above that says "@jprestop
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hsoh-u I have reviewed the code changes and the output from your before and after runs. All of the tests are now passing, after pulling in the disk space modifications from main_v11.1. I approve this PR.
Expected Differences
Support swap_to_north option for rotated lat/lon projection
Allow extra space character around "since" for the time reference string, for example "hours since 2022-02-17 00:00:00" (two spaces after since)
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
/d1/personal/hsoh/git/pull_request/MET_bugfix_2578_rotated_latlon_main_v11.1/bin/plot_data_plane /d1/personal/hsoh/data/MET-2578/test_lfric_lam.nc rotated_latlon.ps 'name="t1p5m"; level="(*,*)";' -v 7
display rotated_latlon.ps
log messages before
log messages after
I don't have other sample files.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [7/05/2023].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes