Feature 2597 disk space

[jprestop]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  No testing was performed. I copied over the same structure that METplus has.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  @georgemccabe is there anything you or I can do to test, or do we just need to get it up there and see if it works well? Is there anything extra I need to do for the use of "$AGENT_TOOLSDIRECTORY" in the free_disk_space.sh script?

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [20230705].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[georgemccabe]

Each job is run in its own environment, so you will need to remove the function call from the job_control job and add it to each unit test job, unit_1a, unit_1b, etc.

[jprestop]

Hi @georgemccabe. Thank you. Can you elaborate on what you mean be "job_control job"?

remove the function call from the job_control job

[jprestop]

@georgemccabe Nevermind, I think I just figured it out. :)

[jprestop]

HI @georgemccabe. Thanks for figuring out the problem and helping me to solve it. All of the tests are passing now. I have requested a re-review.

[georgemccabe]

Looks good and all tests passed. You could remove the spaces from the 2 files to trigger runs. I approve.