Feature #2476 tc_pairs_diag take 2

[JohnHalleyGotway]

Expected Differences

This is the 2nd pull request for #2476. In TC-Pairs, we need to move the call to filter_tracks() down after the call to derive_consensus(). Otherwise, we discard the consensus member tracks for UEMN_CONS prior to using them to define the consensus.

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Ran locally to confirm that this fixes the behavior.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Inspect the GHA testing workflow run. The only diffs should be the introduction of a new TC-Pairs output file and also an unrelated issue with the derivation of PBL observations.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
  Already included in earlier PR Feature 2476 tc pairs diag #2694.

• Do these changes include sufficient testing updates? [Yes]
  Already included in earlier PR Feature 2476 tc pairs diag #2694.

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  
  New output file is added:

    tc_pairs/al092022_20220926_DIAGNOSTICS_CONSENSUS.tcst

Expect to see an unrelated PB2NC difference flagged as well:

COMPARING pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc
file1: /data/output/met_test_truth/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc
file2: /data/output/met_test_output/pb2nc_indy/nam.20210311.t00z.prepbufr.tm00.pbl.nc
ERROR: NetCDF headers differ:
7c7
< 	nobs = 401 ;
---
> 	nobs = 392 ;

• Please complete this pull request review by [Fri 10/6/23].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

I'll note that this GHA run did flag a difference in the tc-pairs output. However, it is just a difference in the order of the output. I downloaded/unpacked the diffs and ran:

cat al132020_CONSENSUS_TRUTH.tcst | sort > TRUTH
cat al132020_CONSENSUS_OUTPUT.tcst | sort > OUTPUT
diff TRUTH OUTPUT

After sorting the output, the diffs go away. The derived BCLP track output used to appear BEFORE the consensus tracks but now appears AFTER them. This makes sense because in MET version 11.1, tc_pairs computed consensus tracks before baselines. This branch moves the computation of consensus tracks after baselines, changing the order in the output.

[sethlinden]

All of these changes look good to me.

[sethlinden]

I reviewed the PR and I approve of the changes. @JohnHalleyGotway looked at the differences in the workflow testing data and it was just a difference in the order of the data.

[sethlinden]

All the code changes look reasonable and make sense.