Bugfix #2449 develop pdf

[JohnHalleyGotway]

Expected Differences

• Do these changes introduce new tools, command line arguments, or configuration file options? [No]
  
  If yes, please describe:
  

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  
  Set up the Sphinx/LaTeX toolchain on my Mac to render the docs as both html and pdf and confirmed that both build well again.

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Review the RTD build log. See both the HTML and PDF version of the docs built by RTD for this branch. Confirm that the PDF is downloadable and that the CRPS equations in Appendix C render well.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
  This fixes the docs.

• Do these changes include sufficient testing updates? [Yes]
  I considered how we might enhance the documentation GHA workflow to test for this type of problem in the future. And I recommended to @jprestop that she consider include testing the PDF generation in the next version of that workflow.

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Please complete this pull request review by [Mon 2/27/23].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s)
  Select: Organization level software support Project or Repository level development cycle Project
  Select: Milestone as the version that will include these changes
• After submitting the PR, select Development issue with the original issue number.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[JohnHalleyGotway]

Note that the difference flagged by the GHA testing workflow run can safely be ignored:

COMPARING tc_pairs/al132020_CONSENSUS.tcst
file1: /data/output/met_test_truth/tc_pairs/al132020_CONSENSUS.tcst
file2: /data/output/met_test_output/tc_pairs/al132020_CONSENSUS.tcst
ERROR: differing number of rows 4486 vs. 1079 for row type TCST_TCMPR between versions 11_0 vs. 11_0

They are expected and described by PR #2466.

[jprestop]

@JohnHalleyGotway Something is different with this downloaded PDF. With the PDF downloaded from the main PR, I can search for "CRPS" and get to the first instance in the Table of Contents and then click on it to get to the CRPS section. With the PDF downloaded from this develop PR, I can search for "CRPS" and get to the first instance in the Table of Contents, but I cannot click on it to get to the CRPS section - it doesn't appear to be a link. This seems strange, and I'm not sure why there were be a difference between the two versions. Can you please see if you can replicate this issue and if so, do you have any idea why it might be happening?

[jprestop]

@JohnHalleyGotway It looks like the sidebar table of contents is no longer there in develop. Let me know if you want to have a screen sharing session for me to demonstrate what I am seeing.

[jprestop]

I downloaded the file in the new PDF link and am no longer experiencing the table of contents problem. I approve this pull request.