Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #2543 #2544

Merged
merged 804 commits into from
May 15, 2023
Merged

Update develop-ref after #2543 #2544

merged 804 commits into from
May 15, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 15, 2023

PR #2543 for issue #2542 intentionally modifies the output of one unit test output file. This expected difference can be seen in this GHA run for develop and is listed below.

COMPARING tc_stat/ALAL2010_rirw.stat
file1: /data/output/met_test_truth/tc_stat/ALAL2010_rirw.stat
file2: /data/output/met_test_output/tc_stat/ALAL2010_rirw.stat
ERROR: differing number of rows 1 vs. 2 for row type CTC between versions 11_1 vs. 11_1 
ERROR: differing number of rows 1 vs. 2 for row type CTS between versions 11_1 vs. 11_1 

Updating develop-ref to get past these expected differences.

JohnHalleyGotway and others added 30 commits December 12, 2022 13:02
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Howard Soh and others added 27 commits April 27, 2023 14:56
* change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT

* change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT

* change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT

* change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT

* change PROJECT ASSIGNMENT to CYCLE ASSIGNMENT

* Added paths to ignore

* Added addt'l paths to ignore, specific to METplus

* Added return that I inadvertently removed

* Removed path added to wrong file

---------

Co-authored-by: jprestop <jpresto@ucar.edu>
…s_mtd

Feature 2521 sonarqube findings mtd and madis2nc
Modifying the structure of the Python version and updating to Python 3.10 to resolve the Import and Extension errors related to urllib3 in ReadTheDocs builds
* Resolve error: more than one instance of overloaded function isnan matches the argument list

* Ensure RTD build passes

* Added std:: in front of isnan for compilation on Hera

* Add -std=c++11 to CXXFLAGS

* Added note about C++11
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu>
Name this workflow the same as its named in the dtcenter/METplus repository.
* Per #2542, in the ContingencyTable class, update gheidke(), gheidke_ec(), gkuiper(), and gerrity() to return bad data for empty contingency tables rather than erroring out.

* Per #2542, modify TC-Stat config file job number 8 that was added for #2425 by adding the  option. That produces output for both the AHWI and BCLP model names. The BCLP contingency table is empty which triggers this runtime error. Tweaking this newly added tests and confirming that it now runs without error demonstrate the fix.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone May 15, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Update develop-ref after #2542 Update develop-ref after #2543 May 15, 2023
@JohnHalleyGotway JohnHalleyGotway merged commit 7b144f6 into develop-ref May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants