Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature #2558 tc_diag_docs edits #2625

Merged
merged 11 commits into from
Jul 25, 2023
Merged

Feature #2558 tc_diag_docs edits #2625

merged 11 commits into from
Jul 25, 2023

Conversation

JohnHalleyGotway
Copy link
Collaborator

Documentation updates from @musgrave-kate and implemented by @jvigh.

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    None

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review doc changes

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]
    None needed

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [Wed 7/26/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

github-actions bot and others added 11 commits June 12, 2023 08:17
@github-actions
Update develop-ref after #2555 and #2561 (#2568)
e7cd0e3 
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu>
Co-authored-by: John and Cindy <halleygotway@Halleys-Mac-mini.local>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Seth Linden <linden@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: davidalbo <dave@ucar.edu>
Co-authored-by: Lisa Goodrich <lisag@ucar.edu>
Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Fix Python environment issue (#2407)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406)
fix #2380 develop override (#2382)
fix #2408 develop empty config (#2410)
fix #2390 develop compile zlib (#2404)
fix #2412 develop climo (#2422)
fix #2437 develop convert (#2439)
fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix #2452 develop airnow (#2454)
fix #2449 develop pdf (#2464)
fix #2402 develop sonarqube (#2468)
fix #2426 develop buoy (#2475)
fix 2518 dtypes appf docs (#2519)
fix 2531 compilation errors (#2533)
fix #2531 compilation_errors_configure (#2535)
@JohnHalleyGotway
Per #2558, change TC-DIAG to TC-Diag and consistently use TC-DLand.
bc63fbf
@JohnHalleyGotway
Per #2558, update the flowchart for 11.1.0 and describe TC-Diag in th…
0c8c0c8 
…e overview section.
@metplus-bot
Merge remote-tracking branch 'origin/develop-ref' into develop
c86f187
@JohnHalleyGotway
Merge remote-tracking branch 'origin/develop' into feature_2558_tc_di…
8983804 
…ag_docs
@JohnHalleyGotway
Per #2558, update the user's guide chapter about TC-Diag
13a72e4
@jvigh
As per #2558, adding some changes to the documentation. Added more ov…
c153962 
…erview and background on the TC-Diag tool and the purpose of diagnostics. Added subsubheadings for the config sections.
@JohnHalleyGotway
Update tc-diag.rst
0266e7a 
Fix underline length warning message
@JohnHalleyGotway
Per #2558, replace ATCFID with TECH
8c5df2e
@JohnHalleyGotway
Merge branch 'main_v11.1' into feature_2558_tc_diag_docs
1b01855
@jvigh
As per #2558, making changes to incorporate Kate Musgrave's feedback …
ca8e60d 
…on the TC-Diag tool documentation.
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Jul 25, 2023
@JohnHalleyGotway JohnHalleyGotway linked an issue Jul 25, 2023 that may be closed by this pull request
Revise TC-Diag documentation for version 11.1.0 #2558
Closed
20 tasks
@JohnHalleyGotway JohnHalleyGotway merged commit c32f4ed into main_v11.1 Jul 25, 2023
2 checks passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_2558_tc_diag_docs branch July 25, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
MET-11.1.0 Development
Status: ✅ Done
Milestone
MET 11.1.0
Development

Successfully merging this pull request may close these issues.

Revise TC-Diag documentation for version 11.1.0
3 participants
@JohnHalleyGotway @metplus-bot @jvigh