Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update develop-ref after #2555 and #2561 #2568

Merged
merged 814 commits into from
Jun 12, 2023
Merged

Update develop-ref after #2555 and #2561 #2568

merged 814 commits into from
Jun 12, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 12, 2023

These are differences flagged in the NB20230612 nightly build for the develop branch.

PR #2555 for issue #2168 adds a new TC-Diag output file and modifies the NetCDF output of TC-RMW:

ERROR: folder MET-develop-ref/test_output missing 1 files
    tc_diag/tc_diag_AL092022_GFSO_2022092400_cyl_grid_parent.nc 

and

file1: MET-develop-ref/test_output/tc_rmw/tc_rmw_hwrf_gonzalo.nc
ERROR: NetCDF headers differ:
file1: MET-develop-ref/test_output/tc_rmw/tc_rmw_pressure_lev_out.nc
ERROR: NetCDF headers differ:

PR #2561 for issue #2532 populates the AAL and BAL wind columns in the TCMPR line type. There are a total of 62 diffs which look like this:

ERROR: found   104 differences in row type TCST_TCMPR   column AAL_WIND_34   - max abs: 10228.25 
ERROR: found   151 differences in row type TCST_TCMPR   column BAL_WIND_34   - max abs: 10226.5 
ERROR: found    95 differences in row type TCST_TCMPR   column AAL_WIND_50   - max abs: 10083.5 
ERROR: found   151 differences in row type TCST_TCMPR   column BAL_WIND_50   - max abs: 10089 
ERROR: found    73 differences in row type TCST_TCMPR   column AAL_WIND_64   - max abs: 10055.5 
ERROR: found   126 differences in row type TCST_TCMPR   column BAL_WIND_64   - max abs: 10049 

Howard Soh and others added 30 commits January 9, 2023 15:20
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
* Updated module and config files

* Reverting to what was in develop
JohnHalleyGotway and others added 27 commits May 5, 2023 09:19
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu>
Name this workflow the same as its named in the dtcenter/METplus repository.
* Per #2542, in the ContingencyTable class, update gheidke(), gheidke_ec(), gkuiper(), and gerrity() to return bad data for empty contingency tables rather than erroring out.

* Per #2542, modify TC-Stat config file job number 8 that was added for #2425 by adding the  option. That produces output for both the AHWI and BCLP model names. The BCLP contingency table is empty which triggers this runtime error. Tweaking this newly added tests and confirming that it now runs without error demonstrate the fix.
* Per 2540, added library name prefixes to log file names

* Per #2485, allow user to specify compiler name/version and python name/version modules to load

* Fix equality statement

* Added more documentation at the top
Updated HSS and HSS_EC definitions with CPC input
Co-authored-by: John and Cindy <halleygotway@Halleys-Mac-mini.local>
@JohnHalleyGotway JohnHalleyGotway added this to the MET 11.1.0 milestone Jun 12, 2023
@JohnHalleyGotway JohnHalleyGotway merged commit e7cd0e3 into develop-ref Jun 12, 2023
JohnHalleyGotway added a commit that referenced this pull request Jul 31, 2023
* Update develop-ref after #2555 and #2561 (#2568)

Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu>
Co-authored-by: John and Cindy <halleygotway@Halleys-Mac-mini.local>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Seth Linden <linden@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: davidalbo <dave@ucar.edu>
Co-authored-by: Lisa Goodrich <lisag@ucar.edu>
Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Fix Python environment issue (#2407)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406)
fix #2380 develop override (#2382)
fix #2408 develop empty config (#2410)
fix #2390 develop compile zlib (#2404)
fix #2412 develop climo (#2422)
fix #2437 develop convert (#2439)
fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix #2452 develop airnow (#2454)
fix #2449 develop pdf (#2464)
fix #2402 develop sonarqube (#2468)
fix #2426 develop buoy (#2475)
fix 2518 dtypes appf docs (#2519)
fix 2531 compilation errors (#2533)
fix #2531 compilation_errors_configure (#2535)

* Per #2582, update unit_plot_tc.xml to use the -save_data option.

* modified the config for mode regarding multivar_intensity_flag

* #2633 Set the default seeps_p1_thresh to >=0.1&&<=0.85

* #2633 Added default setting of seeps_p1_thresh

* Per #2633, small tweaks to the config file comments and documentation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: David Albo <dave@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

10 participants