Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the SEEPS p1_thresold to >=0.1&&<=0.85 #2633

Closed
21 tasks
hsoh-u opened this issue Jul 31, 2023 · 0 comments · Fixed by #2634
Closed
21 tasks

Set the SEEPS p1_thresold to >=0.1&&<=0.85 #2633

hsoh-u opened this issue Jul 31, 2023 · 0 comments · Fixed by #2634
Assignees
@hsoh-u
Labels
MET: Configuration priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Milestone
MET 11.1.0

Comments

@hsoh-u
Copy link
Collaborator

hsoh-u commented Jul 31, 2023

Replace italics below with details for this issue.

Describe the Enhancement

From Rachel North and Marion Mittermaier marion.mittermaier@metoffice.gov.uk

I support Marion’s suggestion of having the default seeps_p1_thresh value set to >=0.1&&<=0.85, rather than setting it to NA. This is recommended in the original Rodwell et al (2010) paper which defines the score.

Plus, as Marion says, for a novice user this makes the set-up easier.

Time Estimate

2 hours

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@hsoh-u hsoh-u added type: enhancement Improve something that it is currently doing alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jul 31, 2023
@hsoh-u hsoh-u added this to the MET 11.1.0 milestone Jul 31, 2023
@hsoh-u hsoh-u self-assigned this Jul 31, 2023
hsoh-u pushed a commit that referenced this issue Jul 31, 2023
#2633 Set the default seeps_p1_thresh to >=0.1&&<=0.85
9a904b5
hsoh-u pushed a commit that referenced this issue Jul 31, 2023
#2633 Added default setting of seeps_p1_thresh
f03eedc
@JohnHalleyGotway JohnHalleyGotway linked a pull request Jul 31, 2023 that will close this issue
Feature #2633 seeps default p1 threshold #2634
Merged
15 tasks
@JohnHalleyGotway JohnHalleyGotway added requestor: UK Met Office United Kingdom Met Office MET: Configuration priority: high High Priority and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jul 31, 2023
JohnHalleyGotway added a commit that referenced this issue Jul 31, 2023
@JohnHalleyGotway
Per #2633, small tweaks to the config file comments and documentation
1125b72
JohnHalleyGotway added a commit that referenced this issue Jul 31, 2023
@hsoh-u @github-actions
@metplus-bot @JohnHalleyGotway @davidalbo
Feature #2633 seeps default p1 threshold (#2634)
4137ccb 
* Update develop-ref after #2555 and #2561 (#2568)

Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: Seth Linden <linden@seneca.rap.ucar.edu>
Co-authored-by: jprestop <jpresto@ucar.edu>
Co-authored-by: Daniel Adriaansen <dadriaan@ucar.edu>
Co-authored-by: John and Cindy <halleygotway@Halleys-Mac-mini.local>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: hsoh-u <hsoh@ucar.edu>
Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Seth Linden <linden@ucar.edu>
Co-authored-by: lisagoodrich <33230218+lisagoodrich@users.noreply.github.com>
Co-authored-by: davidalbo <dave@ucar.edu>
Co-authored-by: Lisa Goodrich <lisag@ucar.edu>
Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com>
Co-authored-by: j-opatz <59586397+j-opatz@users.noreply.github.com>
Fix Python environment issue (#2407)
fix definitions of G172 and G220 based on comments in NOAA-EMC/NCEPLIBS-w3emc#157. (#2406)
fix #2380 develop override (#2382)
fix #2408 develop empty config (#2410)
fix #2390 develop compile zlib (#2404)
fix #2412 develop climo (#2422)
fix #2437 develop convert (#2439)
fix for develop, for #2437, forgot one reference to the search_parent for a dictionary lookup.
fix #2452 develop airnow (#2454)
fix #2449 develop pdf (#2464)
fix #2402 develop sonarqube (#2468)
fix #2426 develop buoy (#2475)
fix 2518 dtypes appf docs (#2519)
fix 2531 compilation errors (#2533)
fix #2531 compilation_errors_configure (#2535)

* Per #2582, update unit_plot_tc.xml to use the -save_data option.

* modified the config for mode regarding multivar_intensity_flag

* #2633 Set the default seeps_p1_thresh to >=0.1&&<=0.85

* #2633 Added default setting of seeps_p1_thresh

* Per #2633, small tweaks to the config file comments and documentation

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: metplus-bot <97135045+metplus-bot@users.noreply.github.com>
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Co-authored-by: David Albo <dave@ucar.edu>
Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsoh-u hsoh-u

Labels
MET: Configuration priority: high High Priority requestor: UK Met Office United Kingdom Met Office type: enhancement Improve something that it is currently doing
Projects
No open projects
MET-11.1.0 Development
Status: ✅ Done
Milestone
MET 11.1.0
Development

Successfully merging a pull request may close this issue.

Feature #2633 seeps default p1 threshold dtcenter/MET
2 participants
@hsoh-u @JohnHalleyGotway