Feature 2231 unstructured grid

[hsoh-u]

Expected Differences

The capability of unstructured grid is implemented, but not completed.

• --enable-ugrid is added to the configure, default is without ugrid capability.
  • At seneca, atlas and eckit libraries are installed at /d1/projects/MET/MET_releases/external_libs/gnu_8.3.0
  • The configuration for seneca is updated at internal/scripts/environment/development.seneca
• Updated configurations, see below
  • added
• Find variables by looking at the level setting (L and P options only) if the given name does not exist:
  • search the variable "<name>_<DDD><uuu>", "temperature_<DDD><uuu>
    • DDD: vertical level from level setting, pressure or height
    • uuu: unit, optional, ignore the unit if exists, for example, hPa
  • for example,name = "temperature"; level = "P1000-500"; is given
  • result: temperature_500hPa, temperature_700hPa, temperature_850hPa, and temperature_925hPa are selected
• Four unit tests are added
  • point_stat
    • MPAS diagnostic file VS prefburf
    • MPAS output file VS prefburf
  • grid_stat:
    • MPAS diagnostic VS. GFS (grib2)
    • MPAS diagnostic VS. MPAS output
  • four configuration files were added
    • internal/test_unit/config/GridStatConfig_ugrid_mpas
    • internal/test_unit/config/GridStatConfig_ugrid_mpas_diag
    • internal/test_unit/config/PointStatConfig_ugrid_mpas_diag
    • internal/test_unit/config/PointStatConfig_ugrid_mpas_out
  • $MET_TEST_INPUT/ugrid_data is added

Error messages if "file_type = NETCDF_UGRID" is configured at the configuration file but MET was built without "--enable-ugrid" option:

ERROR  :
ERROR  : Met2dDataFileFactory::new_met_2d_data_file() -> data file type "FileType_UGrid" is not activated. Recompile with the --enable-ugrid option"
ERROR  :

Not completed items:

• GHA is not ready because of missing Atlas and eckit libraries for the Docker

• The grid_stat output as the unstructured grid is not supported

  • The regrid option has to be configured for the grid_stat between unstructured grid inputs

• Documentation: not done

• Unit test

  • the unit test of the unstructured grid is not conditional
  • did not set <grid_nc> output with grid_stat because of parsing error

• Do these changes introduce new tools, command line arguments, or configuration file options? [Yes]
  
  If yes, please describe:
  

• File type NETCDF_UGRID is added

• Three configurations are added to GridStatConfig and PointStatConfig

  • ugrid_max_distance_km = 30;
  • ugrid_user_map_config: to override metadata settings (dimension and variable names)
  • ugrid_coordinates_file: to specify the static metadata file (for MPAS)

• Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
  
  If yes, please describe:
  

Pull Request Testing

• Describe testing already performed for these changes:
  

Added in the unit test (commands and configurations)

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  
  Test with other MPAS input.
  Test with LFRic data (I did not test LFRic data)
  The build is ready at /d1/personal/hsoh/git/pull_request/MET_feature_2231_unstructured_grid/bin

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

Working on this

• Do these changes include sufficient testing updates? [Yes]

Four unit tests are added (see above)

• Will this PR result in changes to the test suite? [Yes]
  
  If yes, describe the new output and/or changes to the existing output:
  

more outputs from the four unit tests

• Please complete this pull request review by [Fill in date].
  

Pull Request Checklist

See the METplus Workflow for details.

• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[DanielAdriaansen]

Documentation is still needed, but functionality with point_stat and grid_stat has been tested with MPAS output for two meshes. Great work @hsoh-u !

I approve, and look forward to expanding on this for the next beta.

[willmayfield]

Ran a few tests with point_stat (diag files vs bufr) and grid_stat (diag files vs diag files, results on climo file grid), using MPAS diag files with pressure levels in separate netcdf variables. Used separate lines in the config for these variables. Results were as expected and run times reasonable for a high resolution mesh. Approving!

[JohnHalleyGotway]

Thanks @hsoh-u for all this excellent work, and thanks to @DanielAdriaansen and @willmayfield for advising on and reviewing it. I'm proceeding with the merge into develop for inclusion in the MET-12.0.0-beta2 release.

[willmayfield]

Great work @hsoh-u !!! And thank you @DanielAdriaansen and @JohnHalleyGotway !