Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reformatting the TCDIAG line type written by the TC-Pairs tool #240

Closed
3 of 22 tasks
bikegeek opened this issue Oct 31, 2023 · 0 comments · Fixed by #287
Closed
3 of 22 tasks

Support reformatting the TCDIAG line type written by the TC-Pairs tool #240

bikegeek opened this issue Oct 31, 2023 · 0 comments · Fixed by #287
Assignees
Labels
component: METdataio METdataio: General METdataio: Load Tropical Cyclone Data priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing

Comments

@bikegeek
Copy link
Collaborator

bikegeek commented Oct 31, 2023

Describe the Enhancement

The TCDIAG line type is written by the TC-Pairs MET tool when the -diag command line argument is used. When diagnostic data is provided and matched to track data, each TCMPR line is followed by a TCDIAG line containing the diagnostic values corresponding to that point.

This issue is to parse/reformat this TCDIAG data, as needed, so that it can be used by the tcmpr plotter code in METplotpy.

A sample TC-Pairs output file containing TCDIAG lines can be found in:
seneca:/d1/projects/MET/MET_regression/develop/NB20240228/MET-develop/test_output/tc_pairs/al092022_20220926_DIAGNOSTICS.tcst

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

TCDiag Project (2770043)

Define the Metadata

Assignee

  • Select Minna Win
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues

Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version

  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@bikegeek bikegeek added type: enhancement Improve something that it is currently doing priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone METdataio: General METdataio: Load Tropical Cyclone Data component: METdataio labels Oct 31, 2023
@bikegeek bikegeek added this to the METdataio-3.0.0 milestone Oct 31, 2023
@bikegeek bikegeek self-assigned this Oct 31, 2023
@JohnHalleyGotway JohnHalleyGotway changed the title Support reformatting TCDiag linetypes Support reformatting the TCDIAG line type written by the TC-Pairs tool Feb 28, 2024
bikegeek added a commit that referenced this issue Mar 26, 2024
…rs output, includes labelling all TCMPR headers
@bikegeek bikegeek linked a pull request Mar 31, 2024 that will close this issue
14 tasks
@bikegeek bikegeek closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: METdataio METdataio: General METdataio: Load Tropical Cyclone Data priority: high High Priority required: FOR OFFICIAL RELEASE Required to be completed in the official release for the assigned milestone type: enhancement Improve something that it is currently doing
Projects
Status: 🏁 Done
Development

Successfully merging a pull request may close this issue.

1 participant