Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 240 reformat tcdiag #287

Merged
merged 50 commits into from
Apr 2, 2024
Merged

Conversation

bikegeek
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

on 'seneca' using the /d1/personal/mwin/miniconda3/envs/mp_analysis_env conda environment

 run unit tests
 run benchmark 
 generate the reformatted data for sample TC-Pairs output that contains TCMPR and TCDIAG linetype data
 use the output from reformatter to generate TCMPR time series (points with connecting lines) and boxplot plots
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

work resides on 'seneca' under /d1/projects/METdataio_Reformat_TCDiag

 - METdataio **feature_240_reformat_tcdiag** branch
 - use the conda environment on 'seneca': **/d1/personal/mwin/miniconda3/envs/mp_analysis_env**
 - copy the setup_env.bash to your working directory and make necessary changes, then source it to set up the 
    PYTHONPATH, etc.
 - copy the data file under the **/d1/projects/METdataio_Reformat_TCDiag/DATA** to your working directory (or use
    the data in this location by setting the appropriate path in the **input_data_dir** of the **reformat_stat.yaml** config
    file (see the tcdiag_reformat.yaml file for reference)
 - generate the reformatted TCDIAG linetype data (now consolidated with the corresponding TCMPR linetype data into 
    the same row):


    _python $DATAIO/METreformat/write_stat_ascii.py $DATAIO/METreformat/tcdiag_reformat.yaml_

    

 Verify that all headers are labelled, with TCMPR and TCDIAG columns 
      TCMPR columns are AMODEL, BMODEL, ...,MAX_WIND_STDEV
      TCDIAG columns (for this data) are: DIAG_SOURCE, ...,PW01
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [Yes ]

    If yes, describe the new output and/or changes to the existing output:
    benchmarking "tests" for the ECNT and TCDIAG linetype using pandas 1.5x and pandas 2.2 are incorporated into the
    Github workflow

    testing for correct reformatting of the TCDIAG and TCMPR linetype data added to existing test_reformatting.py code.


  • Please complete this pull request review by before beta4.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

bikegeek and others added 30 commits March 26, 2024 17:51
…rs output, includes labelling all TCMPR headers
experiment with benchmarks
@bikegeek bikegeek added this to the METdataio-3.0.0 milestone Mar 31, 2024
@bikegeek bikegeek linked an issue Mar 31, 2024 that may be closed by this pull request
22 tasks
Copy link
Contributor

@hankenstein2 hankenstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All headers are labeled correctly

@hankenstein2 hankenstein2 merged commit 09c997d into develop Apr 2, 2024
9 checks passed
@bikegeek bikegeek deleted the feature_240_reformat_tcdiag branch April 17, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Support reformatting the TCDIAG line type written by the TC-Pairs tool
2 participants