-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 240 reformat tcdiag #287
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs output, includes labelling all TCMPR headers
experiment with benchmarks
…CDiag reformatting
…feature_240_reformat_tcdiag
…nter/METdataio into feature_240_reformat_tcdiag
… up artifact saving
…ut artifact instructions they do not work.
no longer needed
renaming to avoid problems with github workflow coverage
…nter/METdataio into feature_240_reformat_tcdiag
…nter/METdataio into feature_240_reformat_tcdiag
22 tasks
hankenstein2
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All headers are labeled correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
on 'seneca' using the /d1/personal/mwin/miniconda3/envs/mp_analysis_env conda environment
work resides on 'seneca' under /d1/projects/METdataio_Reformat_TCDiag
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes ]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [Yes ]
If yes, describe the new output and/or changes to the existing output:
benchmarking "tests" for the ECNT and TCDIAG linetype using pandas 1.5x and pandas 2.2 are incorporated into the
Github workflow
testing for correct reformatting of the TCDIAG and TCMPR linetype data added to existing test_reformatting.py code.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes