-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance METdataio schema to handle new/modified MPR and ORANK columns introduced for MET 12.0.0 beta6 #320
Closed
11 of 26 tasks
Labels
component: load
Tasks related to the database loading
priority: blocker
Blocker
requestor: NOAA/EMC
NOAA Environmental Modeling Center
required: FOR OFFICIAL RELEASE
Required to be completed in the official release for the assigned milestone
type: enhancement
Improve something that it is currently doing
Milestone
Comments
JohnHalleyGotway
added
type: enhancement
Improve something that it is currently doing
alert: NEED ACCOUNT KEY
Need to assign an account key to this issue
component: load
Tasks related to the database loading
priority: blocker
Blocker
requestor: NOAA/EMC
NOAA Environmental Modeling Center
required: FOR OFFICIAL RELEASE
Required to be completed in the official release for the assigned milestone
labels
Aug 1, 2024
28 tasks
22 tasks
Created issue #321 for the METreformat module to address additional columns added to the MPR linetype |
@bikegeek FYI, the dtcenter/MET#2924 issue was completed today and the final PR merged. You can find updated MPR and ORANK data tomorrow in the output from the MET nightly build run on seneca. |
bikegeek
moved this from 🟢 Ready
to 🏗 In progress
in METplus-Analysis-6.0.0 Development
Aug 22, 2024
bikegeek
moved this from 🏗 In progress
to 🎯 Up Next
in METplus-Analysis-6.0.0 Development
Aug 23, 2024
bikegeek
moved this from 🎯 Up Next
to 🏗 In progress
in METplus-Analysis-6.0.0 Development
Aug 23, 2024
bikegeek
added a commit
that referenced
this issue
Aug 24, 2024
bikegeek
added a commit
that referenced
this issue
Aug 24, 2024
bikegeek
added a commit
that referenced
this issue
Aug 24, 2024
bikegeek
pushed a commit
that referenced
this issue
Aug 27, 2024
15 tasks
bikegeek
added a commit
that referenced
this issue
Aug 28, 2024
* Fix pwd value * Issue #320 updates for MPR and ORANK linetype changes * Fix indentation * Issue #320 updates to MPR and ORANK linetypes * Issue #320 schema updates to reflect changes to MPR and ORANK linetypes. Test, config, and test data. * Skip testing MPR linetype in reformatter. There were changes to the columns: names and additional columnsthat will break this test until the METreformat module is updated. * Issue #320 fixed syntax error * Add pip install of pytest * Issue #320 tests to verify that the renamed column names were created and the new columns are present. * Issue #320 config file used to test that the new schema was loaded. * Update update_for_6_0_beta6.sql fixed the ADD COLUMN lines for ORANK --------- Co-authored-by: Minna Win <minnawin@dakota.rap.ucar.edu>
bikegeek
moved this from 🏗 In progress
to 🔎 In review
in METplus-Analysis-6.0.0 Development
Aug 29, 2024
github-project-automation
bot
moved this from 🔎 In review
to 🏁 Done
in METplus-Analysis-6.0.0 Development
Aug 29, 2024
jprestop
removed
the
alert: NEED ACCOUNT KEY
Need to assign an account key to this issue
label
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: load
Tasks related to the database loading
priority: blocker
Blocker
requestor: NOAA/EMC
NOAA Environmental Modeling Center
required: FOR OFFICIAL RELEASE
Required to be completed in the official release for the assigned milestone
type: enhancement
Improve something that it is currently doing
Describe the Enhancement
Issue dtcenter/MET#2924 and corresponding pull requests dtcenter/MET#2939 and dtcenter/MET#2942 made changes to the MPR and ORANK line types. The METdataio schema needs to be updated to handle the diffs described below:
CLIMO_MEAN
is renamedOBS_CLIMO_MEAN
.CLIMO_STDEV
is renamedOBS_CLIMO_STDEV
.CLIMO_CDF
is renamedOBS_CLIMO_CDF
.FCST_CLIMO_MEAN
andFCST_CLIMO_STDEV
are added to the end of the line.CLIMO_MEAN
is renamedOBS_CLIMO_MEAN
.CLIMO_STDEV
is renamedOBS_CLIMO_STDEV
.FCST_CLIMO_MEAN
andFCST_CLIMO_STDEV
are added to the end of the line.Please see updated MPR line type and ORANK line type tables.
@bikegeek, it is not clear to me if changes are needed in METplotpy, METcalcpy, and METviewer. I'm not sure if/how data from these columns are used in those components. Please let me know if you'd like me to write up additional issues for them.
METreformat code for the MPR linetype is impacted due to the addition of new columns:
#321
Time Estimate
1 day?
Sub-Issues
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
Labels
Projects and Milestone
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
Branch name:
feature_<Issue Number>_<Description>
Pull request:
feature <Issue Number> <Description>
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version
The text was updated successfully, but these errors were encountered: