Feature 320 update schema mpr orank

[bikegeek]

Pull Request Testing

• Describe testing already performed for these changes:
  

1. on test host 'dakota', loaded sample MPR and ORANK data (point_stat and ensemble_stat MET output respectively) onto the database
2. Cloned the feature_320_update_schema_mpr_orank branch and used the mv_mysql.sql script to load the data
3. From the feature branch, ran the tests under METdataio/METdbLoad/tests/update_schema_6.0_beta6 and verified tests passed
4. Sample data (as tarball) is included in the METdataio/METdbLoad/tests/update_schema_6.0_beta6/Data directory

• Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  

1. verify that the METdataio/METdbLoad/sql/updates/update_for_6_0_beta6.sql has captured the following changes:

for MPR (line_data_mpr table):

• CLIMO_MEAN is renamed OBS_CLIMO_MEAN
• CLIMO_STDEV is renamed OBS_CLIMO_STDEV
• CLIMO_CDF is renamed OBS_CLIMO_CDF

and two columns are added:

• FCST_CLIMO_MEAN
• FCST_CLIMO_STDEV

for ORANK (line_data_orank table):

• CLIMO_MEAN is renamed OBS_CLIMO_MEAN
• CLIMO_STDEV is renamed OBS_CLIMO_STDEV

and two columns added:

• FCST_CLIMO_MEAN
• FCST_CLIMO_STDEV

2. If available, use the sample data in METdataio/METdbLoad/tests/update_schema_6.0_beta6/Data and load onto a local database using the updated METdataio/METdbLoad/sql/mv_mysql.sql and verify that the tables have the expected updates.

• Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

• Do these changes include sufficient testing updates? [Yes]

• Will this PR result in changes to the test suite? [No]
  
  If yes, describe the new output and/or changes to the existing output:
  

• Do these changes introduce new SonarQube findings? [yes]
  
  If yes, please describe:
  duplicate code findings

• Please complete this pull request review by Wednesday September 4.
  

Pull Request Checklist

See the METplus Workflow for details.

• Add any new Python packages to the METplus Components Python Requirements table.
• Review the source issue metadata (required labels, projects, and milestone).
• Complete the PR definition above.
• Ensure the PR title matches the feature or bugfix branch name.
• Define the PR metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the version that will include these changes
  Select: Coordinated METplus-X.Y Support project for bugfix releases or METdataio-X.Y.Z Development project for official releases
• After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
• After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
• Close the linked issue and delete your feature or bugfix branch from GitHub.

[mollybsmith-noaa]

You have a copy-paste error on lines 14 and 15 of METdbLoad/sql/updates/update_for_6_0_beta6.sql, but otherwise everything looks good.

[bikegeek]

Good catch! I made the changes.

…

On Wed, Aug 28, 2024 at 2:42 PM Molly Smith ***@***.***> wrote: ***@***.**** requested changes on this pull request. You have a copy-paste error on lines 14 and 15 of METdbLoad/sql/updates/update_for_6_0_beta6.sql, but otherwise everything looks good. — Reply to this email directly, view it on GitHub <#322 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA4UJHW7SJRS56A5XKWVORLZTYY2HAVCNFSM6AAAAABNHEMUXGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRXGIZTANBYG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[mollybsmith-noaa]

Looks good!