Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the functionality to add a line (horizontal or vertical ) to the plots #140

Closed
21 tasks
TatianaBurek opened this issue Aug 10, 2021 · 1 comment · Fixed by #196
Closed
21 tasks

Add the functionality to add a line (horizontal or vertical ) to the plots #140

TatianaBurek opened this issue Aug 10, 2021 · 1 comment · Fixed by #196
Assignees
@TatianaBurek
Labels
reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project type: new feature Make it do something new
Milestone
METplotpy-1.1.0

Comments

@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Aug 10, 2021 •
edited by TaraJensen
Loading

Describe the New Feature

METviewer has a special field <plot_cmd> to add an extra feature to the plot using Rscript functions. Mostly this field is used to add vertical or horizontal line. For example, y=1 line.:
<plot_cmd>abline(h=1, col="blue")</plot_cmd>

This feature is not secure and should not be used as is. But it is important that we continue to support the addition of user specific lines.

To implement this in Python, we need :

Corresponding issue in METviewer:
dtcenter/METviewer#323

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2792541

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TatianaBurek TatianaBurek added the type: new feature Make it do something new label Aug 10, 2021
@TatianaBurek TatianaBurek added this to the METplotpy-1.1 milestone Aug 10, 2021
@TatianaBurek TatianaBurek self-assigned this Aug 10, 2021
@TatianaBurek TatianaBurek mentioned this issue Aug 18, 2021
Closed
21 tasks
@TatianaBurek TatianaBurek changed the title Add the functionality to add a line (horizontal, vertical or inclined) to the plots Add the functionality to add a line (horizontal or vertical ) to the plots Aug 18, 2021
@TaraJensen TaraJensen added reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project labels Feb 9, 2022
TatianaBurek added a commit that referenced this issue Feb 10, 2022
@TatianaBurek
add custom lines #140
1fe5df6
TatianaBurek added a commit that referenced this issue Feb 10, 2022
@TatianaBurek
get parameters for the custom lines #140
9143218
TatianaBurek added a commit that referenced this issue Feb 10, 2022
@TatianaBurek
add a special method to initialise custom lines configuration #140
6c720bb
TatianaBurek added a commit that referenced this issue Feb 10, 2022
@TatianaBurek
add custom lines #140
61d612b
TatianaBurek added a commit that referenced this issue Feb 10, 2022
@TatianaBurek
add a method to add custom lines #140
7b1e80b
TatianaBurek added a commit that referenced this issue Feb 10, 2022
@TatianaBurek
add custom lines #140
37a35db
TatianaBurek added a commit that referenced this issue Feb 11, 2022
@TatianaBurek
change the name of attribute from colors to colors_list #140
bb1edc2
TatianaBurek added a commit that referenced this issue Feb 11, 2022
@TatianaBurek
change the name of attribute from caption_color to caption_col #140
8f8ce6d
TatianaBurek added a commit that referenced this issue Feb 11, 2022
@TatianaBurek
add custom lines #140
d67ab2f
TatianaBurek added a commit that referenced this issue Feb 11, 2022
@TatianaBurek
add custom lines #140
84719f6
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
issue #140 update test to reflect change to base_plot.py
72de595
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
issue #140 update test to reflect change to base_plot.py
3695a54
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
issue #140 update test to reflect change to base_plot.py and director…
d01f53a 
…y structure
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
issue #140 reverted to original directory structure
4b42960
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 skip test, requires large dataset and special packages
5ad1158
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 tests skipped, need updating to reflect changes to the histogram…
1419b47 
… code
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 updates to test to reflect changes to base_plot.py
7022efc
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 updated test to reflect change to base_plot.py
bc5084d
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 update to reflect change to base_plot.py
f3c7a7e
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 skipping, these tests require different packages and large sampl…
2b5e4ef 
…e datasets
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 fixed import, tests are skipped-they require special packages an…
2a19a59 
…d data
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 update to reflect change in base_plot.py
728b2e0
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 modifications to order of tests and skip image testing to allow …
b65e92a 
…proper cleanup. Image test is not a reliable way to test if the generated image matches to an expected image due to differences between machines
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 scikit image error, skipping image comparison
1815231
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 skip image comparison- depends on which machine this test is run…
672bcae 
…ning
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 skip image comparison- depends on which machine is running this …
56a9e48 
…test
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 removed unused imports
4776b38
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 removed unused import to sys
4c5acb5
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 remove unused import of sys
10a68bd
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 remove unused import of sys
2b88bc6
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 remove unused import to sys
ff8d6aa
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 remove unused sys import
e88be28
bikegeek added a commit that referenced this issue Feb 17, 2022
@bikegeek
#140 remove unused imports for sys and pytest
8e41657
bikegeek pushed a commit that referenced this issue Feb 17, 2022
#140 skip image comparison, fails on linux hosts
7b5997c
bikegeek pushed a commit that referenced this issue Feb 17, 2022
#140 skip image comparison
304dd1f
bikegeek pushed a commit that referenced this issue Feb 17, 2022
#140 skip image comparison
b9fdb53
bikegeek pushed a commit that referenced this issue Feb 17, 2022
#140 skip image comparison
2558515
bikegeek pushed a commit that referenced this issue Feb 17, 2022
#140 skip image comparison
1e75c21
bikegeek pushed a commit that referenced this issue Feb 17, 2022
#140 skip image comparison
adae1d3
bikegeek added a commit that referenced this issue Feb 17, 2022
@georgemccabe @bikegeek
feature 140 fix import of hovmoeller (#197)
4633689 
* ignore pycache files

* fix import of config

* fix import of constants

* added test to ensure import of subset of package works correctly. The import tests are based on how the package is imported in real examples such as METplus use cases

* changed imports to be relative to package so that all imports will still work. METplotpy/metplotpy does not need to be added to python path to find the files in the package. updated pytests so that they do not have import errors

* changed scripts that will be called directly to use full paths to imports of metplotpy functions instead of relative paths -- relative paths are not allowed when calling a script directly

* removed pycache files from repo

* added missing dunder init file

* added another missing dunder init file

* added another missing dunder init file

* changed more imports

* added another pytest for the import commands used in another METplus use case

* get correct path to config file even if pytest is run outside of the test/hovmoeller directory

* change output directory to the current directory, which corresponds to the directory where the test resides

* while testing Issue #140, found input data directory setting is pointing to a non-existent directory

* while testing Issue #140 fixed the imports for this test

* Update base_plot.py

proposed change to provide more consistency with imports in other plots

* modifications based on changes to the base_plot.py code

* changes to test based on updates to base_plot.py

* updates based on changes to base_plot.py

* updates based on changes to base_plot.py

* Revert "while testing Issue #140 fixed the imports for this test"

This reverts commit c5efd2b.

* fixed relative import

* issue #140 update test to reflect change to base_plot.py

* issue #140 update test to reflect change to base_plot.py

* reorganized tests based on plot type

* Moved to appropriate sub-directories

* Moved to appropriate sub-directory

* Moved to subdirectory

* issue #140 update test to reflect change to base_plot.py and directory structure

* issue #140 reverted to original directory structure

* #140 skip test, requires large dataset and special packages

* #140 tests skipped, need updating to reflect changes to the histogram code

* only a test fixture in this file, but updated the METPLOTPY_BASE to reflect changes to base_plot.py

* #140 updates to test to reflect changes to base_plot.py

* #140 updated test to reflect change to base_plot.py

* #140 update to reflect change to base_plot.py

* #140 skipping, these tests require different packages and large sample datasets

* #140 fixed import, tests are skipped-they require special packages and data

* #140 update to reflect change in base_plot.py

* #140 modifications to order of tests and skip image testing to allow proper cleanup.  Image test is not a reliable way to test if the generated image matches to an expected image due to differences between machines

* #140 scikit image error, skipping image comparison

* #140 skip image comparison- depends on which machine this test is running

* #140 skip image comparison- depends on which machine is running this test

* #140 removed unused imports

* #140 removed unused import to sys

* #140 remove unused import of sys

* #140 remove unused import of sys

* #140 remove unused import to sys

* #140 remove unused sys import

* #140 remove unused imports for sys and pytest

* #140 skip image comparison, fails on linux hosts

* #140 skip image comparison

* #140 skip image comparison

* #140 skip image comparison

* #140 skip image comparison

* #140 skip image comparison

Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Co-authored-by: Minna Win <minnawin@seneca.rap.ucar.edu>
Co-authored-by: bikegeek <3753118+bikegeek@users.noreply.github.com>
Co-authored-by: bikegeek <minnawin@ucar.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TatianaBurek TatianaBurek

Labels
reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project type: new feature Make it do something new
Projects
None yet
Milestone
METplotpy-1.1.0
Development

Successfully merging a pull request may close this issue.

Issue/140 add line dtcenter/METplotpy
3 participants
@bikegeek @TatianaBurek @TaraJensen