Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the functionality to add a line (horizontal, vertical) to the plots #323

Closed
21 tasks
TatianaBurek opened this issue Aug 18, 2021 · 0 comments · Fixed by #373
Closed
21 tasks

Add the functionality to add a line (horizontal, vertical) to the plots #323

TatianaBurek opened this issue Aug 18, 2021 · 0 comments · Fixed by #373
Assignees
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project type: enhancement Improve something that it is currently doing

Comments

@TatianaBurek
Copy link
Collaborator

TatianaBurek commented Aug 18, 2021

Describe the Enhancement

METviewer has a special field <plot_cmd> to add an extra feature to the plot using Rscript functions. Mostly this field is used to add vertical or horizontal line. For example, y=1 line.:
<plot_cmd>abline(h=1, col="blue")</plot_cmd>

This feature is not secure and should not be used as is. But it is important that we continue to support the addition of user specific lines.
We will add this functionality in Python scripts but need the supporting changes in METviewer:

  • change UI in METviewer (instead of providing R command let the user to specify the line using new fields).
  • update XML with new tags

Corresponding issue in METplotpy:
dtcenter/METplotpy#140

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

2702691

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@TatianaBurek TatianaBurek added the type: enhancement Improve something that it is currently doing label Aug 18, 2021
@TatianaBurek TatianaBurek added this to the METviewer 4.1 milestone Aug 18, 2021
@TatianaBurek TatianaBurek self-assigned this Aug 18, 2021
@TatianaBurek TatianaBurek changed the title Add the functionality to add a line (horizontal, vertical or inclined) to the plots Add the functionality to add a line (horizontal, vertical) to the plots Aug 18, 2021
@TatianaBurek TatianaBurek added alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Nov 23, 2021
@TatianaBurek TatianaBurek added alert: NEED ACCOUNT KEY Need to assign an account key to this issue and removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required labels Feb 4, 2022
@TaraJensen TaraJensen added alert: NEED MORE DEFINITION Not yet actionable, additional definition required reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Feb 4, 2022
@TatianaBurek TatianaBurek linked a pull request Feb 14, 2022 that will close this issue
12 tasks
TatianaBurek added a commit that referenced this issue Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED MORE DEFINITION Not yet actionable, additional definition required reporting: DTC NCAR Base NCAR Base DTC Project reporting: DTC NOAA R2O NOAA Research to Operations DTC Project type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants