Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for setting control members in EnsembleStat and GenEnsProd #1236

Closed
21 tasks
georgemccabe opened this issue Nov 2, 2021 · 1 comment · Fixed by #1357
Closed
21 tasks

Add support for setting control members in EnsembleStat and GenEnsProd #1236

georgemccabe opened this issue Nov 2, 2021 · 1 comment · Fixed by #1357

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Nov 2, 2021

Support for this argument was added in dtcenter/MET#1905

Describe the New Feature

Support for ENSEMBLE_STAT_CTRL_INPUT_TEMPLATE/DIR should be added. This was recently added to GenEnsProd so code from that wrapper could likely be borrowed to implement it.

Acceptance Testing

List input data types and sources.
Describe tests required for new functionality.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the new feature down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

New Feature Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added priority: high High Priority type: new feature Make it do something new alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle METplus: Configuration MET: Ensemble Verification labels Nov 2, 2021
@georgemccabe georgemccabe added this to the METplus-4.1.0 milestone Nov 2, 2021
@georgemccabe georgemccabe self-assigned this Nov 2, 2021
@georgemccabe
Copy link
Collaborator Author

Also add support for new MET config variables ens_member_ids and control_id in EnsembleStat and GenEnsProd (see dtcenter/MET#2001 and dtcenter/MET#2007).

@georgemccabe georgemccabe changed the title Add support for setting -ctrl argument in EnsembleStat Add support for setting control members in EnsembleStat and GenEnsProd Jan 13, 2022
georgemccabe added a commit that referenced this issue Jan 13, 2022
…d support for setting ens_member_ids and control_id in GenEnsProd and EnsembleStat MET config files
@georgemccabe georgemccabe removed alert: NEED MORE DEFINITION Not yet actionable, additional definition required alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle labels Jan 13, 2022
@georgemccabe georgemccabe linked a pull request Jan 13, 2022 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant