Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 1842 StatAnalysis - multiple issues #1869

Merged
merged 88 commits into from
Oct 24, 2022

Commits on Sep 28, 2022

  1. clean up

    georgemccabe committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    ab0dda9 View commit details
    Browse the repository at this point in the history
  2. per #1842, add support for setting multiple jobs for StatAnalysis wra…

    …pper using STAT_ANALYSIS_JOB<n>, clean up indentation
    georgemccabe committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    04db77b View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2022

  1. Configuration menu
    Copy the full SHA
    8c5983d View commit details
    Browse the repository at this point in the history
  2. skip setting env var for JOBS since it is now a list instead of a str…

    …ing and not used in the plotting scripts
    georgemccabe committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    4e7db5f View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. fixed broken unit test by using wrapped StatAnalysis config file inst…

    …ead of using out-of-date file that should no longer be used
    georgemccabe committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    5b007f9 View commit details
    Browse the repository at this point in the history
  2. remove files that should be generated by tests if they already exists…

    … to prevent tests from passing when they should not
    georgemccabe committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    c325ed9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a44c866 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    08d621f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    88f1fb8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3fc2aee View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    3ec43d0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    09d4839 View commit details
    Browse the repository at this point in the history
  9. temporarily disable unit test to ensure that changes to remove MakePl…

    …ots do not break before adding other logic to StatAnalysis wrapper
    georgemccabe committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    a8946f7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    191f811 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    8fb7a6f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c039349 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    3f73c7d View commit details
    Browse the repository at this point in the history
  14. changed logic to format lists when they are read and added support fo…

    …r setting groups of list items that can be looped over, ci-run-diff
    georgemccabe committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    4a9e3ca View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. per #1842, add quotation marks around name/level/units that were read…

    … from the FCST/OBS_VAR<n> variables and around level values read from FCST/OBS_LEVEL_LIST, ci-run-diff
    georgemccabe committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    e644194 View commit details
    Browse the repository at this point in the history
  2. fixed unit test to match change to get_level_list function that now a…

    …dds quotation marks to format the values instead of handling that later in the processing
    georgemccabe committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    3bc2e88 View commit details
    Browse the repository at this point in the history
  3. per #1842, change logic to handle padding HHMMSS values to still supp…

    …ort HHHMMSS (3 digits of hour). Updated tests to handle example from removed configuration file in internal/tests/pytests/plotting
    georgemccabe committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    d97ceb9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7739d2c View commit details
    Browse the repository at this point in the history
  5. clean up logic that loops over 2 lists and performs the same action o…

    …n each, add comments to describe the intended behavior
    georgemccabe committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    ce3a33c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4647b07 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d350c61 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    2097047 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    504b990 View commit details
    Browse the repository at this point in the history
  10. per #1842, moved logic to set fcst/obs beg/end string template sub va…

    …lues into helper function to clean up logic and make it more readable, ci-run-diff
    georgemccabe committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    86ac6d9 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2022

  1. refactored wrapper to be more readable, use relativedelta for hour/le…

    …ad offsets to be consistent with other wrappers, ci-run-diff
    georgemccabe committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    92b2def View commit details
    Browse the repository at this point in the history
  2. refactored wrapper to be more readable, use relativedelta for hour/le…

    …ad offsets to be consistent with other wrappers, ci-run-diff
    georgemccabe committed Oct 4, 2022
    Configuration menu
    Copy the full SHA
    6238de4 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2022

  1. Configuration menu
    Copy the full SHA
    f7a23fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3512997 View commit details
    Browse the repository at this point in the history
  3. combine logic to process loop lists and group lists to consolidate lo…

    …gic and to be able to handle a loop list that contains a group of items, e.g. FCST_LEAD_LIST1, FCST_LEAD_LIST2, ci-run-diff
    georgemccabe committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    dc0e239 View commit details
    Browse the repository at this point in the history
  4. formatting

    georgemccabe committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    c749660 View commit details
    Browse the repository at this point in the history
  5. Added test to ensure that reading FCST_LEAD_LIST1, FCST_LEAD_LIST2, e…

    …tc. works as expected. Moved logic to set config_dict to function, changed default values to unset hour lists, set hour lists as needed in tests.
    georgemccabe committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    83405d4 View commit details
    Browse the repository at this point in the history
  6. added logic to compute init_beg/end from valid_beg/end and forecast l…

    …eads, and vice versa. ci-run-diff
    georgemccabe committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    37b42c5 View commit details
    Browse the repository at this point in the history
  7. fixed logic that was using date beg + 23:59:59 for the end time if no…

    … hours are set instead of using date END + 23:59:59, ci-run-diff
    georgemccabe committed Oct 5, 2022
    Configuration menu
    Copy the full SHA
    fd89fcb View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Configuration menu
    Copy the full SHA
    a7250ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    32ec575 View commit details
    Browse the repository at this point in the history
  3. refactored logic to remove unnecessary arguments, changed logic that …

    …computes all combinations of runtime settings so that it is understandable by other developers, added documentation
    georgemccabe committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    3a0ac73 View commit details
    Browse the repository at this point in the history
  4. changed logic to call function that copies over relevant config list …

    …settings instead of performing a deep copy of self.c_dict since many of those settings are not needed for runtime settings, ci-run-diff
    georgemccabe committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    8eaf348 View commit details
    Browse the repository at this point in the history
  5. more cleanup

    georgemccabe committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    77f029c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2022

  1. Configuration menu
    Copy the full SHA
    da6c638 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8dc34e3 View commit details
    Browse the repository at this point in the history
  3. clean up formatting

    georgemccabe committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    42babcb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a4bd994 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5c1de4a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c4b1bc8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    12a2d9a View commit details
    Browse the repository at this point in the history
  8. set INIT/VALID_BEG/END even if no corresponding HOUR list was specifi…

    …ed to ensure that the files processed are restricted to the time range specified in the config file with INIT/VALID_BEG/END. ci-run-diff to see if this changes any of the use case output
    georgemccabe committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    64ad315 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. updated use case to read from a different point_stat stat file that h…

    …as matching times to produce output when restricting the obs valid range to the range specified in the config file
    georgemccabe committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    ee0f21c View commit details
    Browse the repository at this point in the history
  2. clean up code, rearrange functions in order they are used, updated co…

    …mments, fixed pylint complaints, replaced object variables not set in init, etc.
    georgemccabe committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    e50acdd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e7f719a View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2022

  1. Changed logic to use full [INIT/VALID]_[BEG/END] times instead of tru…

    …ncating YYYYMMDD. If only YYYYMMDD is set in the _END time and no hours are specified in [FCST/OBS]_[INIT/VALID]_HOUR, then set HHMMSS to 23:59:59 to ensure full day is processed to preserve old behavior.
    georgemccabe committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f6a64fb View commit details
    Browse the repository at this point in the history
  2. removed logic to build filename template if not specified by the user…

    … since it is not used, users should specify the template they want explicitly
    georgemccabe committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    f25fa86 View commit details
    Browse the repository at this point in the history
  3. remove run_at_time method since it will no longer be called since LOO…

    …P_ORDER = times logic no longer exists. keeping stub of function because some of the logic can be used if/when StatAnalysis becomes a RuntimeFreq wrapper to be able to specify different time frequencies to run. It will always process the full range of times specified for now
    georgemccabe committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    39bc1a1 View commit details
    Browse the repository at this point in the history
  4. moved variables to store datetime notation to set YYYYMMDD and YYYYMM…

    …DD_HHMMSS into constant variable since it is referenced frequently, ci-run-diff
    georgemccabe committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    49b7a2f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Removed rest of logic that reads filename type since we now require t…

    …o set a filename template for [dump_row_file] and [out_stat_file] instead of generating a default template. Add error checking to ensure that at least 1 model is specified with MODEL<n>* variables and the corresponding filename template variable is set if [dump_row_file] or [out_stat_file] are found in any jobs. Added unit tests to ensure init set catches these cases to alert users of errors before attempting to run
    georgemccabe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    75375b9 View commit details
    Browse the repository at this point in the history
  2. improved list to string logic by handling if quotes already exist whe…

    …n attempting to add them to each item
    georgemccabe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    d0cc48c View commit details
    Browse the repository at this point in the history
  3. made MODEL<n>_OBTYPE optional so users can filter without obtype, rem…

    …ove MODEL<n>_REFERENCE_NAME because it was only used by MakePlots wrapper
    georgemccabe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    3e8b832 View commit details
    Browse the repository at this point in the history
  4. exit non-zero and print an error if any warnings/errors occur when ru…

    …nning build_docs.py script locally to easily see if there are any fixes needed to the docs
    georgemccabe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    acc04d3 View commit details
    Browse the repository at this point in the history
  5. added glossary entry for STAT_ANALYSIS_JOB<n> variable and cleaned up…

    … list of required and optional config variables for StatAnalysis wrapper
    georgemccabe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    9c44e40 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    926d231 View commit details
    Browse the repository at this point in the history
  7. added info specific to StatAnalysis wrapper its Description section a…

    …nd adding info to glossary items about looping over groups of list items
    georgemccabe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    867783f View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fe3c2a0 View commit details
    Browse the repository at this point in the history
  9. added info to note that full day of end time will be processed if onl…

    …y YYYMMDD is specified in VALID/INIT_END
    georgemccabe committed Oct 14, 2022
    Configuration menu
    Copy the full SHA
    6b30b6b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    685d25e View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e978a51 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c5061ab View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2022

  1. Configuration menu
    Copy the full SHA
    6cf90ef View commit details
    Browse the repository at this point in the history
  2. moved utilities to parse time lists from strings to time_util, cleane…

    …d up logic to set command line arguments to simplify how command is built, added documentation to functions and cleaned up code
    georgemccabe committed Oct 17, 2022
    Configuration menu
    Copy the full SHA
    39e2c41 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ac8645 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c91e299 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    665cf09 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. check that changing logic to not set beg or end based on hour list do…

    …es not break existing use cases, ci-run-all-diff
    georgemccabe committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    b563d86 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Configuration menu
    Copy the full SHA
    86b2e42 View commit details
    Browse the repository at this point in the history
  2. change logic to never set fcst/obs_init/valid__beg/end values based o…

    …n hour lists and only set them if explicitly requested in the METplus config
    georgemccabe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    e871d50 View commit details
    Browse the repository at this point in the history
  3. pass runtime settings to set_environment_variables function so that s…

    …tring template substitution on any env var that will be set by wrapper will be performed before calling stat_analysis
    georgemccabe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    653b04c View commit details
    Browse the repository at this point in the history
  4. added logic to substitute string template tags when reading explicit …

    …fcst/obs_init/valid_beg/end values from config. prevent crash when dict values are not set by using get
    georgemccabe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    5f25e89 View commit details
    Browse the repository at this point in the history
  5. started adding tests to ensure fcst/obs_init/valid_beg/end values are…

    … read from METplus config and set in env vars for wrapped MET config file properly
    georgemccabe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    2462db3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6c9a627 View commit details
    Browse the repository at this point in the history
  7. removed setting of legacy environment variables that were set to supp…

    …ort very old wrapped MET config files for StatAnalysis
    georgemccabe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    437e6d6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    a7ef6ef View commit details
    Browse the repository at this point in the history
  9. added rest of new config variables to glossary and fixed formatting t…

    …hat was removing first letter of sentence for CUSTOM_LOOP_LIST
    georgemccabe committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    9d74886 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2022

  1. Configuration menu
    Copy the full SHA
    f1a6892 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Refactored the logic to build the string substitution dictionary and …

    …pass it to other functions instead of recalculating it with potentially incomplete dictionaries as input. Rearranged class functions to be in a more logical order and made functions that shouldn't be called outside of the wrapper private
    georgemccabe committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    1521c09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e7f79e2 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b9a1aa6 View commit details
    Browse the repository at this point in the history