Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cfg to always treat target as host #123

Merged
merged 2 commits into from
Aug 15, 2021
Merged

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Aug 10, 2021

Unfortunately, currently, it seems there is no heuristic that can handle this well...

So at the moment, only approaches that "require the user to explicitly specify" such as environment variables and cfg seem to work.

This PR uses an approach that exposes a cfg to always treat the target as host.

In the future, once rust-lang/cargo#9532 merged, we can support auto-detection of this.

Closes #122

@taiki-e taiki-e changed the title Expose cfg to always treat target as host Add cfg to always treat target as host Aug 11, 2021
@dtolnay dtolnay merged commit 09aba1f into dtolnay:master Aug 15, 2021
@taiki-e taiki-e deleted the target branch August 15, 2021 00:15
bors bot added a commit to taiki-e/cargo-llvm-cov that referenced this pull request Aug 15, 2021
54: Support trybuild (take 2) r=taiki-e a=taiki-e

Fixes #32

The following patch is needed until dtolnay/trybuild#123 is merged:

```toml
[patch.crates-io]
trybuild = { git = "https://github.com/taiki-e/trybuild.git", branch = "target" }
```

---

Tested in the same way as #44 (comment)

Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot added a commit to taiki-e/cargo-llvm-cov that referenced this pull request Aug 15, 2021
54: Support trybuild (take 2) r=taiki-e a=taiki-e

Fixes #32

The following patch is needed until dtolnay/trybuild#123 is merged:

```toml
[patch.crates-io]
trybuild = { git = "https://github.com/taiki-e/trybuild.git", branch = "target" }
```

---

Tested in the same way as #44 (comment)

59: Update clap to 3.0.0-beta.4 r=taiki-e a=taiki-e



Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Trybuild doesn't pass on --target, even when needed
2 participants