Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support trybuild #44

Merged
merged 1 commit into from
Aug 7, 2021
Merged

Support trybuild #44

merged 1 commit into from
Aug 7, 2021

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Aug 7, 2021

Fixes #32

The following patch is needed until dtolnay/trybuild#121 is merged:

UPDATE: dtolnay/trybuild#121 merged and released in trybuild 1.0.44.

@taiki-e taiki-e force-pushed the trybuild branch 2 times, most recently from 3e95622 to 417474f Compare August 7, 2021 13:23
@taiki-e
Copy link
Owner Author

taiki-e commented Aug 7, 2021

$ git clone https://github.com/taiki-e/cargo-llvm-cov.git

$ git clone https://github.com/taiki-e/easy-ext.git

$ cd easy-ext

$ cargo run --manifest-path ../cargo-llvm-cov/Cargo.toml -- llvm-cov
Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ast.rs                            758               218    71.24%          87                 9    89.66%         923               142    84.62%           0                 0         -
error.rs                            3                 3     0.00%           3                 3     0.00%          26                26     0.00%           0                 0         -
iter.rs                           157                23    85.35%          36                 1    97.22%         202                24    88.12%           0                 0         -
lib.rs                            194                28    85.57%          23                 1    95.65%         433                19    95.61%           0                 0         -
to_tokens.rs                       33                14    57.58%          13                 4    69.23%          61                26    57.38%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            1145               286    75.02%         162                18    88.89%        1645               237    85.59%           0                 0         -

$ cd ../cargo-llvm-cov && git checkout trybuild && cd -

$ echo '[patch.crates-io]\ntrybuild = { git = "https://github.com/taiki-e/trybuild.git", branch = "target" }' >> Cargo.toml

$ cargo clean
$ cargo run --manifest-path ../cargo-llvm-cov/Cargo.toml -- llvm-cov
Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ast.rs                            758               170    77.57%          87                 4    95.40%         923                95    89.71%           0                 0         -
error.rs                            3                 1    66.67%           3                 1    66.67%          26                 1    96.15%           0                 0         -
iter.rs                           157                16    89.81%          36                 1    97.22%         202                18    91.09%           0                 0         -
lib.rs                            194                 8    95.88%          23                 1    95.65%         433                 4    99.08%           0                 0         -
to_tokens.rs                       33                 3    90.91%          13                 1    92.31%          61                 5    91.80%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                            1145               198    82.71%         162                 8    95.06%        1645               123    92.52%           0                 0         -

(increased coverage around error.rs used in error handling, which is only tested in ui tests)

@taiki-e
Copy link
Owner Author

taiki-e commented Aug 7, 2021

bors r+

@taiki-e taiki-e closed this Aug 7, 2021
@taiki-e taiki-e reopened this Aug 7, 2021
@taiki-e
Copy link
Owner Author

taiki-e commented Aug 7, 2021

bors retry -- it seems crashed

@bors
Copy link
Contributor

bors bot commented Aug 7, 2021

Build succeeded:

@bors bors bot merged commit b42adf7 into main Aug 7, 2021
@bors bors bot deleted the trybuild branch August 7, 2021 18:06
@taiki-e taiki-e mentioned this pull request Aug 10, 2021
bors bot added a commit that referenced this pull request Aug 15, 2021
54: Support trybuild (take 2) r=taiki-e a=taiki-e

Fixes #32

The following patch is needed until dtolnay/trybuild#123 is merged:

```toml
[patch.crates-io]
trybuild = { git = "https://github.com/taiki-e/trybuild.git", branch = "target" }
```

---

Tested in the same way as #44 (comment)

Co-authored-by: Taiki Endo <te316e89@gmail.com>
bors bot added a commit that referenced this pull request Aug 15, 2021
54: Support trybuild (take 2) r=taiki-e a=taiki-e

Fixes #32

The following patch is needed until dtolnay/trybuild#123 is merged:

```toml
[patch.crates-io]
trybuild = { git = "https://github.com/taiki-e/trybuild.git", branch = "target" }
```

---

Tested in the same way as #44 (comment)

59: Update clap to 3.0.0-beta.4 r=taiki-e a=taiki-e



Co-authored-by: Taiki Endo <te316e89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interoperability with trybuild
1 participant