Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve string parsing in reaction.delta method #325

Merged
merged 4 commits into from
Mar 9, 2024
Merged

Improve string parsing in reaction.delta method #325

merged 4 commits into from
Mar 9, 2024

Conversation

NilsHeunemann
Copy link
Contributor

@NilsHeunemann NilsHeunemann commented Feb 27, 2024

Previously the reaction.delta method would return the potential energy of the transition state when supplying "G ddagger" or "G double dagger". This behavior was unexpected.

After the change synonyms "ddagger" and "double dagger" can also be used with free energy.

  • Improved string parsing that all synonyms for double dagger can be used
  • Added tests that determine if right energy is returned

Checklist

  • The changes include an associated explanation of how/why
  • Test pass
  • Documentation has been updated
  • Changelog has been updated

- Improved string parsing that all synonyms for double dagger can be used
- Added tests that determine if right energy is chosen
@t-young31 t-young31 changed the base branch from master to v1.4.3 March 3, 2024 14:46
@t-young31
Copy link
Member

Hi @NilsHeunemann – this is awesome, thanks. Would you mind:

Then I'm very happy to approve and merge this 🚀

Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (67ed012) to head (475764c).

❗ Current head 475764c differs from pull request most recent head 47f262c. Consider uploading reports for the commit 47f262c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           v1.4.3     #325   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files         209      209           
  Lines       23747    23761   +14     
=======================================
+ Hits        23141    23155   +14     
  Misses        606      606           
Flag Coverage Δ
unittests 97.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NilsHeunemann
Copy link
Contributor Author

Hi, thank you for the quick reply!
I just updated the changelog and added myself to the contributors list.

@t-young31 t-young31 enabled auto-merge (squash) March 9, 2024 14:23
@t-young31 t-young31 merged commit c9c2c2b into duartegroup:v1.4.3 Mar 9, 2024
12 checks passed
@NilsHeunemann NilsHeunemann deleted the better_delta_parsing branch March 9, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants