Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template #326

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Template #326

merged 1 commit into from
Mar 3, 2024

Conversation

t-young31
Copy link
Member

Resolves #320

Also templates v1.4.3


Checklist

  • The changes include an associated explanation of how/why
  • Test pass
  • Documentation has been updated
  • Changelog has been updated

@t-young31 t-young31 linked an issue Mar 3, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.41%. Comparing base (034743c) to head (a073728).

Additional details and impacted files
@@            Coverage Diff             @@
##           v1.4.3     #326      +/-   ##
==========================================
- Coverage   97.44%   97.41%   -0.03%     
==========================================
  Files         209      209              
  Lines       23747    23747              
==========================================
- Hits        23141    23134       -7     
- Misses        606      613       +7     
Flag Coverage Δ
unittests 97.41% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t-young31 t-young31 merged commit 67ed012 into duartegroup:v1.4.3 Mar 3, 2024
13 of 14 checks passed
@t-young31 t-young31 deleted the template_v143 branch March 3, 2024 14:41
t-young31 added a commit that referenced this pull request Mar 9, 2024
* Improve string parsing in reaction.delta method

- Improved string parsing that all synonyms for double dagger can be used
- Added tests that determine if right energy is chosen

* Template (#326)

* Added changelog

---------

Co-authored-by: Tom Young <39765193+t-young31@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Python version in CI
1 participant