-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Duck Player settings UI #4748
Add Duck Player settings UI #4748
Conversation
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on Graphite |
32a00b5
to
95f055e
Compare
40ab3e7
to
0a92af2
Compare
0a92af2
to
1e20bc1
Compare
1e20bc1
to
d3483e0
Compare
4981aed
to
c8e7b54
Compare
d3483e0
to
4a6069c
Compare
c8e7b54
to
01cdb4e
Compare
4a6069c
to
1c70aab
Compare
01cdb4e
to
7d9aa0a
Compare
1c70aab
to
f27c311
Compare
ef92132
to
4330616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the PR the settings don't seem to change but at the top of the stack works. Code wise LGTM though I think we should add more tests :)
7d9aa0a
to
6ec479e
Compare
4330616
to
2680c38
Compare
Task/Issue URL: https://app.asana.com/0/72649045549333/1207551634140420
Description
Steps to test this PR
https://app.asana.com/0/0/1207704461779423/f
Note: There have been changes to the JS integration, so you might need to test these changes on the top of the stack
User preferences "Always" open Duck Player
User preferences "Always ask" trigger overlay
User preferences "Never" stays in YT
UI changes
See https://app.asana.com/app/asana/-/get_asset?asset_id=1207785858877769