Update initial setup message for Duck Player page #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CrisBarreiro and the rest of your teammates on |
11 tasks
CrisBarreiro
force-pushed
the
feature/cris/duckplayer/native-settings
branch
from
40ab3e7
to
0a92af2
Compare
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
from
e7ec676
to
741042d
Compare
CrisBarreiro
force-pushed
the
feature/cris/duckplayer/native-settings
branch
from
0a92af2
to
1e20bc1
Compare
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
from
741042d
to
77a1bdb
Compare
CrisBarreiro
force-pushed
the
feature/cris/duckplayer/native-settings
branch
from
1e20bc1
to
d3483e0
Compare
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
2 times, most recently
from
c9639aa
to
1be170e
Compare
karlenDimla
reviewed
Jul 12, 2024
| @@ -69,6 +70,7 @@ class ContentScopeScriptsJsMessaging @Inject constructor( | |||
| webView.url?.toUri()?.host | |||
| } | |||
| jsMessage?.let { | |||
| Timber.d("Cris Processing message: $it") | |||
There was a problem hiding this comment.
NIT: Just in case you forget to remove this log.
karlenDimla
approved these changes
Jul 12, 2024
CrisBarreiro
force-pushed
the
feature/cris/duckplayer/native-settings
branch
from
d3483e0
to
4a6069c
Compare
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
from
f1130da
to
2057954
Compare
3 tasks
CrisBarreiro
force-pushed
the
feature/cris/duckplayer/native-settings
branch
from
4a6069c
to
1c70aab
Compare
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
from
40fc837
to
d9fa7be
Compare
CrisBarreiro
force-pushed
the
feature/cris/duckplayer/native-settings
branch
from
1c70aab
to
f27c311
Compare
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
2 times, most recently
from
8242a9f
to
fab0899
Compare
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
from
fab0899
to
8d68e61
Compare
CrisBarreiro
force-pushed
the
feature/cris/duckplayer/native-settings
branch
from
ef92132
to
4330616
Compare
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
from
8d68e61
to
1f34224
Compare
3 tasks
This was referenced Aug 14, 2024
Closed
Merged
CrisBarreiro
force-pushed
the
feature/cris/update-initial-setup-duck-player-page
branch
from
1f34224
to
878ad02
Compare
CrisBarreiro
changed the base branch from
feature/cris/duckplayer/native-settings
to
feature/cris/duckplayer/create-module
CrisBarreiro
merged commit 878ad02
into
feature/cris/duckplayer/create-module
5 of 6 checks passed
CrisBarreiro
deleted the
feature/cris/update-initial-setup-duck-player-page
branch
This was referenced Aug 21, 2024
This was referenced Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204920898013511/1207777888338891/f
Description
Steps to test this PR
https://app.asana.com/0/0/1207704461779423/f
Feature 1
Open settings