Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill never prompt to save for site #608

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Autofill never prompt to save for site #608

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85687f0
Added handling for 3rd party password managers
amddg44 Dec 19, 2023
a4606dd
Merge remote-tracking branch 'origin/main' into autofill/anya-never-s…
amddg44 Dec 19, 2023
53d1877
Merge remote-tracking branch 'origin/main' into autofill/anya-never-s…
amddg44 Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Sources/BrowserServicesKit/SecureVault/SecureVaultManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,9 +229,11 @@ extension SecureVaultManager: AutofillSecureVaultDelegate {
autosaveAccountCreatedInSession = false
}

// Do not autosave anything if user has requested to never be prompted to save credentials for this domain
// Do not autosave anything if user has requested to never be prompted to save credentials for this domain and are using DDG as password manager
if let neverPrompt = try vault?.hasNeverPromptWebsitesFor(domain: domain), neverPrompt {
return
guard let passwordManager = passwordManager, passwordManager.isEnabled else {
return
}
}

// Validate the existing account exists and matches the domain and fetch the credentials
Expand Down
Loading