Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill never prompt to save for site #608

Merged
merged 3 commits into from
Dec 28, 2023
Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 20, 2023

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1201645688934642/1205190244970075/f
iOS PR: duckduckgo/iOS#2280
macOS PR: duckduckgo/macos-browser#1991
What kind of version bump will this require?: Patch

Description:
Update for autofill never prompt to save for site support on macOS

Steps to test this PR:

  1. See client PRs

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 changed the title Autofill/anya never save site Autofill never prompt to save for site Dec 20, 2023
Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amddg44 amddg44 merged commit e9c344c into main Dec 28, 2023
5 checks passed
@amddg44 amddg44 deleted the autofill/anya-never-save-site branch December 28, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants