Autofill never save for site #1991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SabrinaTardio
approved these changes
Dec 20, 2023
| if notNowSegmentedControl.segmentCount > 1 { | ||
| notNowSegmentedControl.setShowsMenuIndicator(true, forSegment: 1) | ||
| } | ||
| notNowSegmentedControl.selectedSegment = -1 |
There was a problem hiding this comment.
in what case would this happen?
…ave-site # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Dec 28, 2023
Task/Issue URL: https://app.asana.com/0/1201645688934642/1205190244970075/f iOS PR: duckduckgo/iOS#2280 macOS PR: duckduckgo/macos-browser#1991 What kind of version bump will this require?: Patch Description: Update for autofill never prompt to save for site support on macOS
samsymons
added a commit
that referenced
this pull request
Jan 8, 2024
* main: (35 commits) Update login item failure pixel (#2024) fix turn off sync error message (#2025) DBP: macOS - Scheduler Progress Notifications (#2023) DBP: Implement sign-out flow for DBP (#2009) Switch CI to Xcode 15.1 (#2022) fix(duckplayer): bump CSS for duckplayer nav loop fix (#1982) Bump Submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2006) Bump version to 1.69.0 (99) DBP: Respect foreign constraints when deleting all user's data (#2014) DBP: Respect foreign constraints when deleting all user's data (#2014) Don't force reload tab when restoring state (#2016) Bump version to 1.69.0 (98) Update embedded files Update NetP launch agent logic to include build number (#2015) Always use 'sandbox' Application Support directory for Favicons Fetcher (#2013) Allow calculations in the address bar (#2012) Fix clickable area for buttons in 'Sync with Another Device' view (#2011) Fix for empty autofill state displayed on top of existing password items (#1998) Update error messages (#1999) Autofill never save for site (#1991) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201645688934642/1205190244970075/f
Tech Design URL:
CC:
Description:
Adds the functionality to allow users to choose to "Never Save for this Site" from the autofill save password prompt, with the option to reset this list from the Settings screen.
Steps to test this PR:
Don't Savebutton with the option toNever Ask For This Sitem_mac_autofill_logins_save_login_exclude_site_confirmedSave passwordpromptSave passwordprompt is still presented for other sitesPassword Generationis disabled for this site (no key in the password field and tapping in the field does not trigger the generated password prompt)Password Generationis still enabled for itExcluded Siteswith aResetbutton optionResetbutton and confirm this pixel is fired:m_mac_autofill_settings_reset_excluded_displayedCancelin the action sheet that was presented and confirm this pixel is firedm_mac_autofill_settings_reset_excluded_dismissedResetbutton and choose the redResetoption and confirm this pixel is fired:m_mac_autofill_settings_reset_excluded_confirmedExcluded Sitessection should now be gone (it is only added to the screen when a user has at least 1 site saved asNever Prompt)Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation