Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass config to Autofill script #61

Merged
merged 38 commits into from
Feb 21, 2022
Merged

Pass config to Autofill script #61

merged 38 commits into from
Feb 21, 2022

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Feb 3, 2022 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1201640241287329/f
Tech Design URL: https://app.asana.com/0/481882893211075/1201716942816252/f
CC:

Description:

Steps to test this PR:

  1. Use with this pr: https://app.asana.com/0/0/1201760729306248/f
  2. Modify privacy config manager to use embedded config
  3. Ensure autofill is enabled in macos-config.json
  4. Visit https://duckduckgo.com/email/ and ensure you can sign in
  5. Visit https://privacy-test-pages.glitch.me/autofill/modal.html and https://privacy-test-pages.glitch.me/autofill/form-submission.html and ensure they behave as expected

OS Testing:

  • macOS 10.15
  • macOS 11
Internal references:

Software Engineering Expectations
Technical Design Template

mallexxx and others added 25 commits October 28, 2021 12:34
@mallexxx
Secure Vault autofill Pixel support (#26)
2b4100d 
* add delegate calls after autofilling

* upd with AutofillType
@samsymons @GioSensation
Secure Vault additions (#28)
65b012c 
* Finish note support.

* Note database migration

* Begin working on identities

* Further work on Identities

* Consolidate database migrations.

* Fill out remaining credit card functions.

* Remove unneeded credit card properties.

* Further autofill API work.

* Support cardholder name.

* Fix unit test compilation failures.

* Remove an incorrect marker comment.

* Add better credit card validation.

* Bump the Autofill commit.

* Add tests for the new autofill Get methods.

* Clean up the database access calls.

* Clean up a number of SwiftLint warnings and errors.

* Update the Autofill commit.

* Fill in the autofill type delegate methods.

* Ignore the release script.

* Bump autofill

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

Co-authored-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation @samsymons
Bump autofill to version 3.3.0 (#29)
7ed55a3 
* Bump autofill to version 3.3.0

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

* Update the duckduckgo-autofill submodule commit.

Co-authored-by: Sam Symons <sam@samsymons.com>
@jonathanKingston
Add requiresRunInPageContentWorld to run UserScripts in page world (#30)
6fd3f7d
@samsymons
Ensure that the WKContentWorld usage compiles on iOS. (#32)
a664b0b
@GioSensation
Fix lastName in identity (#33)
094fbcb
@samsymons
Update the credit card table (#34)
aeb2dc2 
* Upgrade the credit card number field to L2.

* Correctly provide the last name for Identity autofill.

* Allow the SecureVaultFactory to return the crypto classes only.

* Ensure that addressStreet2 is encoded and read correctly.

* Update the migration to remove the old column.

* Generate a display title and subtitle for notes.

* Add a new error type for if no L1 key is available.
@bwaresiak
Move content blocking code to BSK (#35)
63fe79d 
* Initial refactoring of content blocking to enable sharing between platforms

* Extracted Content Rules script

* Tweaks based on Mac OS X implementation

* Expand API to enable checking for result of the requested compilation

* Add option to obtain PrivacyFeature settings dictionary

* Add Surrogates user script

* API Tweaks

* Fix tests

* Content Blocking reference tests

* More Pixels

* Add tests for User Scripts and Tracker allowlist

* Reuse sha256 code in tests

* Better Privacy Config tests
@sammacbeth
Add autoconsent as a configurable feature (#39)
6d0dc34
@jonathanKingston
Remove unused TrackingProtectionStats dead code (#41)
1adeb94
@GioSensation
Add identities autofill (#38)
be84a3b 
* Bump autofill pointer

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

* Bump autofill revision

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>

* Bump autofill to latest version

Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@GioSensation
Bump autofill revision (#46)
e105303 
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
@jonathanKingston
Support content scope as a user script (#45)
d9ebd24
@jonathanKingston
Remove content scope files causing warnings (#49)
5f4f5e1
@jonathanKingston
Navigator credentials move (#47)
31f7e31
@bwaresiak
Fix unprotected domains calculation for about:blank urls (#51)
6605419
@bwaresiak
Add Resolver tests and fix cname resolving (#50)
a035fa9
@SlayterDev @bwaresiak
Multiple blocking rule lists (#53)
da3f840 
* Initial implementation to support multiple rules lists

* Make API open for inheritance

* Fix few bugs, update tests

* CTL delegate WIP

* Update ContentBlockerRulesUserScript.swift

* Update ContentBlockerRulesUserScript.swift

* Refactor Content Blocker User Script

* Add missing change information

* Expand error reporting API

* Unit tests for error reporting

* Workaround for missing TDS at startup issue

* Move model processing to work queue

* Kill the app only in case main TDS rule list fails to compile

* Allow for non-TDS rule lists to fail compilation in case setup fails

* Add check for embedded TDS compilation

Co-authored-by: Bartek Waresiak <bartek@duckduckgo.com>
Co-authored-by: ladamski@duckduckgo.com <ladamski@duckduckgo.com>
@shakyShane
Add platform.name to BrowserServices kit (#48)
ebbeada 
* Add platform.name to BrowserServices kit

* be explicit about supported platform names
@ladamski
add clickToPlay config (#56)
03b4298 
Co-authored-by: ladamski@duckduckgo.com <ladamski@duckduckgo.com>
@samsymons
Enable unit tests via Xcode (#57)
10e19a2 
* Have all bundle resources copied to the root directory.

* Remove a duplicate file.
@bwaresiak
Move embedded TDS to platform code (#58)
e1ab233
@SlayterDev
Pass config to Autofill script
1b92718
@SlayterDev
lint
a893734
@SlayterDev
Parentheses
b2746f7
Base automatically changed from release/friends-and-family to main February 9, 2022 13:12
@SlayterDev SlayterDev marked this pull request as ready for review February 16, 2022 20:31
@SlayterDev SlayterDev mentioned this pull request Feb 16, 2022
Merged
1 task
@bwaresiak bwaresiak self-assigned this Feb 17, 2022
@SlayterDev SlayterDev mentioned this pull request Feb 18, 2022
Merged
12 tasks
bwaresiak
bwaresiak approved these changes Feb 21, 2022
View reviewed changes
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@SlayterDev SlayterDev merged commit a263b2f into main Feb 21, 2022
@SlayterDev SlayterDev deleted the brad/autofill-config branch February 21, 2022 14:58
samsymons added a commit that referenced this pull request Feb 23, 2022
@samsymons
Merge branch 'main' into sam/logins-authentication
cd2c427 
* main:
  Content blocking rules caching and publishing (#54)
  Pass config to Autofill script (#61)
  Embed reference tests as submodule (#66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwaresiak bwaresiak bwaresiak approved these changes

@brindy brindy Awaiting requested review from brindy

@mallexxx mallexxx Awaiting requested review from mallexxx

@THISISDINOSAUR THISISDINOSAUR Awaiting requested review from THISISDINOSAUR

@tomasstrba tomasstrba Awaiting requested review from tomasstrba

@samsymons samsymons Awaiting requested review from samsymons

Assignees

@bwaresiak bwaresiak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@SlayterDev @bwaresiak @mallexxx @samsymons @GioSensation @jonathanKingston @sammacbeth @shakyShane @ladamski