Pass config data to Autofill UserScript #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SlayterDev
changed the title
|
@SlayterDev I'd assume it should migrate existing users nicely - I have some problems when testing autofill, basically Dax icon won't show for the email fields even if I change the config to embedded one. |
|
@SlayterDev It works now - question is: shall we display dax icon on websites that are in the feature exception list? |
No to exceptions. The feature would be disabled so we shouldn't show the icon. |
|
I'm asking as I've added website to exception list (manually) but Dax icon is still visible there - tapping on it does nothing. |
bwaresiak
approved these changes
Feb 21, 2022
samsymons
added a commit
that referenced
this pull request
Feb 22, 2022
samsymons
added a commit
that referenced
this pull request
Feb 23, 2022
…ntication # By Alexey Martemyanov (1) and others * sam/logins-filtering-and-sorting: Disable the search field when editing. Waiting for ContentBlockingRules to be applied before navigation (#402) Cookie prompt management (#312) Pass config data to Autofill UserScript (#418) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo/Common/Utilities/UserDefaultsWrapper.swift # DuckDuckGo/Preferences/Model/PreferenceSections.swift # DuckDuckGo/Preferences/View/PrivacySecurityPreferencesTableCellView.xib
jonathanKingston
pushed a commit
that referenced
this pull request
Feb 25, 2022
* Pass config data to Autofill UserScript * Update BSK * Update BSK * Update embedded config hash * Fix dashboard commit * Adopt Autofill source provider * Lint fix * Update BSK reference * Update BSK reference * Update config * Update etag and hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1201640241287329/f
Tech Design URL: https://app.asana.com/0/481882893211075/1201716942816252/f
CC:
Description:
This PR adds remote config support for autofill. Depends on duckduckgo/BrowserServicesKit#61
Steps to test this PR:
macos-config.jsonTesting checklist:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM