Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DuckPlayer] - Create DuckPlayer target and move initially shared code #921

Merged
merged 9 commits into from
Aug 2, 2024
Merged

[DuckPlayer] - Create DuckPlayer target and move initially shared code #921

merged 9 commits into from
Aug 2, 2024

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Jul 31, 2024 •
edited
Loading

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1207614229908937/f
iOS PR: duckduckgo/iOS#3171
macOS PR: duckduckgo/macos-browser#3055
What kind of version bump will this require?: Major

Description:

  • Create a DuckPlayer target to moving Shared code to BSK
  • Move DuckPlayerURLExtension and Tests

Steps to test this PR:

  1. CI should be 🥬

This was referenced Jul 31, 2024
Merged
Merged
@afterxleep afterxleep requested a review from Bunn July 31, 2024 17:21
@afterxleep afterxleep merged commit ebad3db into main Aug 2, 2024
7 checks passed
@afterxleep afterxleep deleted the daniel/duckplayer.extension branch August 2, 2024 14:31
afterxleep added a commit to duckduckgo/macos-browser that referenced this pull request Aug 2, 2024
@afterxleep
[DuckPlayer] 1. Move Extension to BSK and add Init Updates (#3055)
469d285 
Task/Issue URL: https://app.asana.com/0/1204099484721401/1207614229908937/f
BSK PR: duckduckgo/BrowserServicesKit#921

Description:

Steps to test this PR:

Moves DuckPlayerURLextension to BSK
Adds DuckPlayer init parameters for both script (FE requirement for future updates=
afterxleep added a commit to duckduckgo/iOS that referenced this pull request Aug 2, 2024
@afterxleep
[DuckPlayer]. 15. Move DuckPlayer code to BSK (#3171)
06004e9 
Task/Issue URL: https://app.asana.com/0/0/1207614229908937/f
BSK PR: duckduckgo/BrowserServicesKit#921

Description:

Move Extension to BSK
samsymons added a commit that referenced this pull request Aug 3, 2024
@samsymons
Merge branch 'main' into bartek/data-debugging
fe39d1d 
* main:
  [DuckPlayer] - Create DuckPlayer target and move initially shared code (#921)
  Improve CrashLogMessageExtractor memory safety (#909)
samsymons added a commit that referenced this pull request Aug 4, 2024
@samsymons
Merge branch 'main' into sam/add-rmf-message-shown-attribute
44ef02c 
* main:
  [DuckPlayer] - Create DuckPlayer target and move initially shared code (#921)
  Improve CrashLogMessageExtractor memory safety (#909)
samsymons added a commit that referenced this pull request Aug 5, 2024
@samsymons
Merge branch 'main' into sam/vpn-snooze-initial-support
01f19a2 
* main:
  Tweaks to DB API, improved abstractions for better testability. (#913)
  Add RMF `messageShown` attribute (#923)
  [DuckPlayer] - Create DuckPlayer target and move initially shared code (#921)
  Improve CrashLogMessageExtractor memory safety (#909)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bunn Bunn Bunn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afterxleep @Bunn