Tweaks to DB API, improved abstractions for better testability. #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaresiak
commented
Jul 26, 2024
| insertRootFolder(uuid: legacyFavoritesFolderID, into: context) | ||
| } | ||
| try prepareRootFolder(uuid: BookmarkEntity.Constants.rootFolderID) | ||
| try prepareRootFolder(uuid: legacyFavoritesFolderID) | ||
| } |
There was a problem hiding this comment.
This is now made to throw in case query fails.
bwaresiak
commented
Jul 26, 2024
| dbFileURL: URL, | ||
| errorEvents: EventMapping<MigrationErrors>? = nil) -> [String]? { | ||
| public func getFavoritesOrderFromPreV4Model(dbContainerLocation: URL, | ||
| dbFileURL: URL) throws -> [String]? { |
There was a problem hiding this comment.
Instead of using event mapper to handle errors, just throw it from here and handle in client.
bwaresiak
commented
Jul 26, 2024
bwaresiak
changed the title
samsymons
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/856498667320406/1207875839908777/f
iOS PR: duckduckgo/iOS#3143
macOS PR: duckduckgo/macos-browser#3033
What kind of version bump will this require?: Major
Description:
Tweak code to improve error handling and events propagation in Clients. Add protocols for improved testability.
Steps to test this PR:
See platform PRs.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template