Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to register early scripts #930

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

SabrinaTardio
Copy link
Contributor

@SabrinaTardio SabrinaTardio commented Aug 7, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1207981214658241/f
iOS PR: duckduckgo/iOS#3199
macOS PR: duckduckgo/macos-browser#3081
What kind of version bump will this require?: Major/Minor/Patch

Optional:

Tech Design URL:
CC:

Description: Allows to load early script before rules are compiled

Steps to test this PR:

  1. Look at platforms PR

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@SabrinaTardio SabrinaTardio changed the base branch from main to release/180.0.0-1 August 7, 2024 09:15
@SabrinaTardio SabrinaTardio requested a review from mallexxx August 7, 2024 09:18
Copy link
Collaborator

@mallexxx mallexxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see one minor comment

@@ -113,12 +113,14 @@ final public class UserContentController: WKUserContentController {
private let scriptMessageHandler = PermanentScriptMessageHandler()

@MainActor
public init<Pub, Content>(assetsPublisher: Pub, privacyConfigurationManager: PrivacyConfigurationManaging)
public init<Pub, Content>(assetsPublisher: Pub, privacyConfigurationManager: PrivacyConfigurationManaging, earlyAccessScripts: [UserScript] = [])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the naming here may be misleading since we‘re only installing the handlers and the scripts are ignored. A previous naming (earlyAccessHandlers) and some comment would do a better job IMO

@SabrinaTardio SabrinaTardio merged commit 1d50e24 into release/180.0.0-1 Aug 7, 2024
7 checks passed
@SabrinaTardio SabrinaTardio deleted the sabrina/onboarding-fix branch August 7, 2024 12:23
samsymons added a commit that referenced this pull request Aug 7, 2024
* main:
  Bump Privacy Dashboard to v5.0.0 (#919)
  Push domain exclusions to internal release (#928)
  allow to register early scripts (#930)
  Handle contingency settings state on remote config (#926)
  VPN Domain exclusions (internal release) (#918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants