Push domain exclusions to internal release #928
Merged
+24
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task/Issue URL: https://app.asana.com/0/0/1207936340790549/f iOS PR: duckduckgo/iOS#3164 macOS PR: duckduckgo/macos-browser#3045 What kind of version bump will this require?: Patch ## Description Adds BSK support for implements domain exclusions in macOS for internal users only.
This was referenced Aug 6, 2024
|
This was already reviewed in #918, so I'll go the route we usually take and consider this a glorified cherry-pick with CI validation. I've also tested this extensively, I'll do one more round of testing and merge if all looks good to me. |
diegoreymendez
added a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1207987809385256/f BSK PR: duckduckgo/BrowserServicesKit#928 macOS PR: duckduckgo/macos-browser#3076 ## Description Integrates latest macOS BSK changes for supporting domain exclusions.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 7, 2024
Task/Issue URL: https://app.asana.com/0/0/1207987809385256/f BSK PR: duckduckgo/BrowserServicesKit#928 iOS PR: duckduckgo/iOS#3195 ## Description Implements domain exclusions for internal users only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207987809385256/f
iOS PR: duckduckgo/iOS#3195
macOS PR: duckduckgo/macos-browser#3076
What kind of version bump will this require?: Patch
Description
Adds BSK support for implements domain exclusions in macOS for internal users only.
Testing
Please refer to the platform-specific PRs for testing instructions.
Internal references:
Software Engineering Expectations
Technical Design Template