New batch of fixes + integration test improvements #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
Signed-off-by: Emanuele Feliziani <feliziani.emanuele@gmail.com>
GioSensation
commented
Jan 30, 2024
| 'signupWithFormInModal': 'pages/signup-in-modal.html', | ||
| 'loginCovered': 'pages/login-covered.html', | ||
| 'loginMultistep': 'pages/login-multistep.html' | ||
| 'overlay': `${localPagesPrefix}/overlay.html`, |
There was a problem hiding this comment.
Referencing either the local path or the privacy test pages path. I will migrate more and more over time.
GioSensation
commented
Jan 30, 2024
| await page.waitForFunction(selector => Boolean(document.querySelector(selector)?.getAttribute('style')), selector) | ||
| // don't make assertions until the element has been scanned | ||
| const field = page.locator(selector) | ||
| await expect(field).toHaveAttribute('data-ddg-inputtype') |
There was a problem hiding this comment.
I've switched this to use the locator with expect so that playwright automatically pierces the shadow tree and waits for the attribute to be set. Otherwise, I'd have to implement something custom for waitForFunction. This also seems much cleaner.
GioSensation
commented
Jan 30, 2024
| @@ -21,22 +21,25 @@ | |||
| "test:passwords": "PASSWORD_STRESS_TEST=true jest generate.test.js", | |||
| "test:unit": "jest", | |||
| "test:integration": "npm run build && npm run copy-assets && playwright test", | |||
| "test:integration:fast": "playwright test --timeout 10000 --workers 8", | |||
There was a problem hiding this comment.
A shortcut that skips the build, runs with more workers and a shorter timeout so tests fail faster. This is great for faster test iterations. The other is safer (you're always re-creating the build).
GioSensation
commented
Jan 30, 2024
| { "html": "rottentomatoes_signup.html", "expectedFailures": ["emailAddress"], "expectedSubmitFalsePositives": 1 }, | ||
| { "html": "rottentomatoes_signup.html" }, |
shakyShane
approved these changes
Jan 30, 2024
| await page.waitForFunction(selector => Boolean(document.querySelector(selector)?.getAttribute('style')), selector) | ||
| // don't make assertions until the element has been scanned | ||
| const field = page.locator(selector) | ||
| await expect(field).toHaveAttribute('data-ddg-inputtype') |
This was referenced Jan 30, 2024
CDRussell
pushed a commit
to duckduckgo/Android
that referenced
this pull request
Jan 30, 2024
Task/Issue URL: https://app.asana.com/0/1206475855296108/1206475855296108 Autofill Release: https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.1.0 ## Description Updates Autofill to version [10.1.0](https://github.com/duckduckgo/duckduckgo-autofill/releases/tag/10.1.0). ### Autofill 10.1.0 release notes ## What's Changed * Support shadow dom by @GioSensation in duckduckgo/duckduckgo-autofill#485 * New batch of fixes + integration test improvements by @GioSensation in duckduckgo/duckduckgo-autofill#489 * Update password-related json files (2024-01-17) by @daxmobile in duckduckgo/duckduckgo-autofill#474 * Bump playwright from 1.38.1 to 1.40.1 by @dependabot in duckduckgo/duckduckgo-autofill#458 * Update password-related json files (2024-01-26) by @daxmobile in duckduckgo/duckduckgo-autofill#484 * Bump json-schema-to-typescript from 13.1.1 to 13.1.2 by @dependabot in duckduckgo/duckduckgo-autofill#479 **Full Changelog**: duckduckgo/duckduckgo-autofill@10.0.3...10.1.0 ## Steps to test This release has been tested during autofill development. For smoke test steps see [this task](https://app.asana.com/0/1198964220583541/1200583647142330/f). Co-authored-by: GioSensation <GioSensation@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @shakyShane
Asana: https://app.asana.com/0/0/1206048671514097/f
Description
Apart from the usual minor bug fixes, this includes nice updates to the integration tests:
npm run test:integration:fastthat skips recompiling the files and uses shorter timeouts and more workers. This enables faster iterations when working on tests locally 💪.Steps to test
Everything tested.