Skip to content

[DuckPlayer] 26. Fix saved favs when DuckPlayer is disabled #8069

[DuckPlayer] 26. Fix saved favs when DuckPlayer is disabled

[DuckPlayer] 26. Fix saved favs when DuckPlayer is disabled #8069

Triggered via pull request August 28, 2024 15:28
Status Success
Total duration 8m 15s
Billable time 17m
Artifacts

pr.yml

on: pull_request
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

26 warnings and 2 notices
ShellCheck
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
SwiftLint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/ssh-agent@v0.7.0, actions/checkout@v3, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build
Accent color ‘AccentColor’ is not present in any asset catalogs.
Make Release Build: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L34
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L49
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L83
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L100
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L111
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L121
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L132
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Make Release Build
xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify
Unit Tests
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, actions/cache@v3, mikepenz/action-junit-report@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
Unit Tests
xcbeautify 2.11.0 is already installed and up-to-date. To reinstall 2.11.0, run: brew reinstall xcbeautify
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests
Accent color ‘AccentColor’ is not present in any asset catalogs.
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L34
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L49
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L83
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L100
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L111
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L121
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L132
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Unit Tests: PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift#L143
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
Unit Tests
Skipped UnitTests.AutofillLoginListViewModelTests.testWhenBreakageReporterConfigEnabledAndReportAlreadyRecentlySavedThenShowBreakageReporterIsFalse
Unit Tests
Skipped UnitTests.WebCacheManagerTests.testWhenClearedWithDataStoreContainerThenDDGCookiesAreRetained