Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout problem in privacy dashboard #640

Closed
tsekityam opened this issue May 18, 2020 · 3 comments
Closed

Layout problem in privacy dashboard #640

tsekityam opened this issue May 18, 2020 · 3 comments

Comments

@tsekityam
Copy link
Contributor

tsekityam commented May 18, 2020 •
edited
Loading

What did I do

  1. Visit a broken site, e.g. http://12321sdljfghashgf.com/
  2. Open privacy dashboard

What did I see

image

What do I expect

No text overlap at the end of the dashboard

What did I use

iPhone XR with iOS 13.1.1
DuckDuckGo 7.46.0.0
@brindy
Copy link
Contributor

brindy commented May 18, 2020

Thanks for reporting this.

Does this only happen in the error state (ie when it says "Uh-oh, that didn't work.") ?

@tsekityam
Copy link
Contributor Author

Yes, it only happens in error state. Look like we will not enter this function to show/hide footer view when we are in error state.

I am preparing a patch to hide both gatheringView and scoresView in storyboard by default, such that the view will only be visible if above function is executed. How do you think about this patch?

@tsekityam tsekityam mentioned this issue May 18, 2020
Merged
13 tasks
@brindy
Copy link
Contributor

brindy commented May 25, 2020

Merged, thanks!

@brindy brindy closed this as completed May 25, 2020
dus7 added a commit that referenced this issue Jan 29, 2024
@dus7
Fix site: queries escaping with iOS 17 SDK (#640) (#2402)
c1b97c9
samsymons added a commit that referenced this issue Jan 29, 2024
@samsymons
Merge branch 'main' into sam/fix-alpha-build-vpn-embedding
5d0a99a 
* main:
  Fix `site:` queries escaping with iOS 17 SDK (#640) (#2402)
  Prepare release script updates (#2389)
  Adding lastSentDate to broken site report  (#2320)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2382)
  Skip 'Make Release Build' GHA job for Dependabot PRs (#2399)
samsymons added a commit that referenced this issue Jan 30, 2024
@samsymons
Merge branch 'main' into sam/suppress-noisy-vpn-pixels
99c20b0 
# By dependabot[bot] (1) and others
# Via GitHub
* main:
  Reenable toggle on disallowing vpn (#2404)
  Bump BrowserServicesKit to 103.0.2 (#2393)
  Fix the alpha build VPN extension embed script (#2396)
  Fix `site:` queries escaping with iOS 17 SDK (#640) (#2402)
  Prepare release script updates (#2389)
  Adding lastSentDate to broken site report  (#2320)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2382)
  Skip 'Make Release Build' GHA job for Dependabot PRs (#2399)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brindy @tsekityam