Reenable toggle on disallowing vpn #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
approved these changes
Jan 29, 2024
samsymons
added a commit
that referenced
this pull request
Jan 30, 2024
# By dependabot[bot] (1) and others # Via GitHub * main: Reenable toggle on disallowing vpn (#2404) Bump BrowserServicesKit to 103.0.2 (#2393) Fix the alpha build VPN extension embed script (#2396) Fix `site:` queries escaping with iOS 17 SDK (#640) (#2402) Prepare release script updates (#2389) Adding lastSentDate to broken site report (#2320) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2382) Skip 'Make Release Build' GHA job for Dependabot PRs (#2399) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
pushed a commit
that referenced
this pull request
Jan 30, 2024
Task/Issue URL: https://app.asana.com/0/0/1206463994034099/f Description: When “Don’t Allow” is tapped, the dialog is dismissed and the toggle is greyed out. We have to back out of the screen and reopen the VPN screen to give it another attempt. Reenable the button again when the VPN permission is denied. This can be solved by simply reenabling the toggle after it’s been disabled for 2 seconds, something we were already sort of doing to stop spamming. This just slightly reworks the logic to cover more scenarios.
samsymons
added a commit
that referenced
this pull request
Jan 30, 2024
Task/Issue URL: https://app.asana.com/0/0/1206463994034099/f Description: When “Don’t Allow” is tapped, the dialog is dismissed and the toggle is greyed out. We have to back out of the screen and reopen the VPN screen to give it another attempt. Reenable the button again when the VPN permission is denied. This can be solved by simply reenabling the toggle after it’s been disabled for 2 seconds, something we were already sort of doing to stop spamming. This just slightly reworks the logic to cover more scenarios.
samsymons
added a commit
that referenced
this pull request
Feb 4, 2024
* main: (41 commits) Update BSK with autofill 10.1.0 (#2414) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408) Add Autoconsent onByDefault subfeature (#2423) Metadata reverted https://app.asana.com/0/0/1206476969305202/1206481077004998/f metadata updated Release 7.107.0-0 (#2421) More script fixes (#2419) More release script fixes (#2418) Release/7.106.0-4 (#2417) Reenable toggle on disallowing vpn (#2404) (#2416) Don't crash when AppRatingPromptEntity fetch errors (#2388) Add error codes to site breakage reports (#2413) Don't set dryRun for alpha builds (#2412) Add VPN redemption retry event (#2409) Changes to hotfix process (#2406) Release/7.106.0-3 changes (#2411) Fix tab loading (#2410) Improve waitlist invite code checks (#2398) Reenable toggle on disallowing vpn (#2404) Bump BrowserServicesKit to 103.0.2 (#2393) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206463994034099/f
Description:
When “Don’t Allow” is tapped, the dialog is dismissed and the toggle is greyed out. We have to back out of the screen and reopen the VPN screen to give it another attempt.
Reenable the button again when the VPN permission is denied.
This can be solved by simply reenabling the toggle after it’s been disabled for 2 seconds, something we were already sort of doing to stop spamming. This just slightly reworks the logic to cover more scenarios.
Steps to test this PR:
Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template