-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error codes to site breakage reports #2413
Conversation
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something wrong with "branch" : "12-14-feat_macos_allow_direct_navigation_to_breakage_form",
DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and seems fine
* main: (41 commits) Update BSK with autofill 10.1.0 (#2414) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408) Add Autoconsent onByDefault subfeature (#2423) Metadata reverted https://app.asana.com/0/0/1206476969305202/1206481077004998/f metadata updated Release 7.107.0-0 (#2421) More script fixes (#2419) More release script fixes (#2418) Release/7.106.0-4 (#2417) Reenable toggle on disallowing vpn (#2404) (#2416) Don't crash when AppRatingPromptEntity fetch errors (#2388) Add error codes to site breakage reports (#2413) Don't set dryRun for alpha builds (#2412) Add VPN redemption retry event (#2409) Changes to hotfix process (#2406) Release/7.106.0-3 changes (#2411) Fix tab loading (#2410) Improve waitlist invite code checks (#2398) Reenable toggle on disallowing vpn (#2404) Bump BrowserServicesKit to 103.0.2 (#2393) ...
Task/Issue URL: https://app.asana.com/0/72649045549333/1205982573174191/f
Tech Design URL: https://app.asana.com/0/0/1206225370438701/f
CC: @jonathanKingston
Description:
Send error and http status codes within reports
Steps to test this PR:
Load https://expired.badssl.com/
Send report
Put a breakpoint and validate that the report contains error
Validate that the report contains httpErrorCodes too