Update SwiftLint build phase to check for the Homebrew install directory on Apple Silicon #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
requested review from
brindy,
bwaresiak and
THISISDINOSAUR
as code owners
jonathanKingston
approved these changes
Nov 23, 2021
samsymons
added a commit
that referenced
this pull request
Nov 27, 2021
* develop: Stop web views from loading during Fire button calls (#1010) Fix `Unprotected Sites` toolbar was kept hidden. (#990) Add a check for the Homebrew location on M1 Macs. (#1000) Bump version number Fixes and enhanced stats for recently added debug pixel (#1007) Fix Core Data deadlocks (#989) Update version number Improvements to cookie cleaning (#1002) Remove unused TrackingProtectionStats dead code (#996) Update version Update version number Update TDS dependency after latest release (#995) Support for Tracker Exceptions (#991) Use temp unprotected list and user list for all features (#993) Run ESLint on scripts (#984) Move to using mutation observing to reduce page overhead (#985) Disabling SafeBrowsing due to privacy implications (#992)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1201350547885701/f
Tech Design URL:
CC:
Description:
This PR updates the SwiftLint build phase to check for the default Homebrew install directory on M1 Macs. If you install Homebrew on an M1 Mac and try to build out of the box, it will fail with an error stating that SwiftLint is not installed.
The fix was to add a new section to the build phase that amends the
PATHif it sees that the Apple Silicon install directory for Homebrew is present:Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM