Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused TrackingProtectionStats dead code #996

Merged

Conversation

jonathanKingston
Copy link
Collaborator

@jonathanKingston jonathanKingston commented Nov 6, 2021

Task/Issue URL: https://app.asana.com/0/0/1201333032847219/f
Tech Design URL:
CC:

Description:

Removes unused code from content blocker rules.

Steps to test this PR:

  1. Open browser console check for errors on page load.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPad

OS Testing:

  • iOS 13
  • iOS 14
  • iOS 15

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template
When ready for review, remember to post the PR in MM


@SlayterDev SlayterDev merged commit 11b2bde into duckduckgo:develop Nov 8, 2021
@jonathanKingston jonathanKingston deleted the jkt/remove-dead-code branch November 8, 2021 17:16
samsymons added a commit that referenced this pull request Nov 27, 2021
* develop:
  Stop web views from loading during Fire button calls (#1010)
  Fix `Unprotected Sites` toolbar was kept hidden. (#990)
  Add a check for the Homebrew location on M1 Macs. (#1000)
  Bump version number
  Fixes and enhanced stats for recently added debug pixel (#1007)
  Fix Core Data deadlocks (#989)
  Update version number
  Improvements to cookie cleaning (#1002)
  Remove unused TrackingProtectionStats dead code (#996)
  Update version
  Update version number
  Update TDS dependency after latest release (#995)
  Support for Tracker Exceptions (#991)
  Use temp unprotected list and user list for all features (#993)
  Run ESLint on scripts (#984)
  Move to using mutation observing to reduce page overhead (#985)
  Disabling SafeBrowsing due to privacy implications (#992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants