Properly refresh home page favorites view when updating favorites display mode #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
force-pushed
the
dominik/sync-ffs-favorites-refresh-home-page
branch
from
6fac824 to
23d0618
Compare
SabrinaTardio
approved these changes
Nov 13, 2023
samsymons
added a commit
that referenced
this pull request
Nov 14, 2023
# By Brad Slayter (1) and others # Via Graeme Arthur (2) and others * develop: Add NetP widget (#2142) Normalize ampUrl in breakage pixel (#2154) Bump submodules/privacy-reference-tests from `0d23f76` to `7519c3d` (#2135) Properly refresh home page favorites view when updating favorites display mode (#2148) # Conflicts: # DuckDuckGo/AppDelegate.swift
samsymons
added a commit
that referenced
this pull request
Nov 16, 2023
* develop: (36 commits) Rolls back a BSK change by mistake Updates BSK Updates BSK Document LinkPresentation usage (#2172) Autofill "Never Save for this Site" feature (#2104) Use upstream fastlane 2.217.0 (#2161) Update about screen (#2152) Fixes a crasher due to a test line merged by mistake. (#2162) remove return user pixel (#2146) Revert to auto signing (#2158) BSK changes for NetP iOS Geoswitching (#2141) Update sync e2e tests to new setup flow (#2151) Fix for duplicated "atb" in Pixel request (#2139) Updating tests to support latest reference tests (#2145) Add NetP widget (#2142) Normalize ampUrl in breakage pixel (#2154) Update embedded files Update version number Bump submodules/privacy-reference-tests from `0d23f76` to `7519c3d` (#2135) Properly refresh home page favorites view when updating favorites display mode (#2148) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201493110486074/1205918060547867/f
Description:
Listen to changes to favorites display mode also in HomeViewController and reload favorites view as needed.
Steps to test this PR:
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template