Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize ampUrl in breakage pixel #2154

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Conversation

SlayterDev
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1201602070177732/1205869658195882/f
Tech Design URL:
CC:

Description:
This PR ensures ampUrls sent with breakage pixels are normalized.

Steps to test this PR:

  1. No functional changes. Submit a breakage report and ensure no issues.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev requested review from a team and THISISDINOSAUR and removed request for a team November 13, 2023 14:53
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SlayterDev SlayterDev merged commit 20176c4 into develop Nov 13, 2023
10 checks passed
@SlayterDev SlayterDev deleted the brad/breakage-param-encoding branch November 13, 2023 18:54
samsymons added a commit that referenced this pull request Nov 13, 2023
* develop:
  Normalize ampUrl in breakage pixel (#2154)
  Bump submodules/privacy-reference-tests from `0d23f76` to `7519c3d` (#2135)
  Properly refresh home page favorites view when updating favorites display mode (#2148)
  Add DesignResourcesKit to SyncUI (#2147)
samsymons added a commit that referenced this pull request Nov 14, 2023
# By Brad Slayter (1) and others
# Via Graeme Arthur (2) and others
* develop:
  Add NetP widget (#2142)
  Normalize ampUrl in breakage pixel (#2154)
  Bump submodules/privacy-reference-tests from `0d23f76` to `7519c3d` (#2135)
  Properly refresh home page favorites view when updating favorites display mode (#2148)

# Conflicts:
#	DuckDuckGo/AppDelegate.swift
samsymons added a commit that referenced this pull request Nov 16, 2023
* develop: (36 commits)
  Rolls back a BSK change by mistake
  Updates BSK
  Updates BSK
  Document LinkPresentation usage (#2172)
  Autofill "Never Save for this Site" feature (#2104)
  Use upstream fastlane 2.217.0 (#2161)
  Update about screen (#2152)
  Fixes a crasher due to a test line merged by mistake. (#2162)
  remove return user pixel (#2146)
  Revert to auto signing (#2158)
  BSK changes for NetP iOS Geoswitching (#2141)
  Update sync e2e tests to new setup flow (#2151)
  Fix for duplicated "atb" in Pixel request (#2139)
  Updating tests to support latest reference tests (#2145)
  Add NetP widget (#2142)
  Normalize ampUrl in breakage pixel (#2154)
  Update embedded files
  Update version number
  Bump submodules/privacy-reference-tests from `0d23f76` to `7519c3d` (#2135)
  Properly refresh home page favorites view when updating favorites display mode (#2148)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants