Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Fastlane notes file temporarily #2270

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Dec 14, 2023

Task/Issue URL: https://app.asana.com/0/414235014887631/1206166614257286/f
Tech Design URL:
CC:

Description:

This PR removes the Fastlane notes file. See Asana link for context.

Steps to test this PR:

  1. Make sure that the file has been removed and that there's no other form of review notes being provided to Fastlane

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from jaceklyp December 14, 2023 06:39
@samsymons samsymons merged commit f6a4d4d into main Dec 14, 2023
12 checks passed
@samsymons samsymons deleted the sam/remove-fastlane-notes branch December 14, 2023 15:59
samsymons added a commit that referenced this pull request Dec 15, 2023
* main:
  Update Autofill Logins copy (#2246)
  Remove the reconnect/disconnect logic from the connection tester (#2272)
  Remove the Fastlane notes file temporarily (#2270)
  remove QR code from save recovery PDF view (#2271)
samsymons added a commit that referenced this pull request Dec 21, 2023
* main: (35 commits)
  Add Sync feature flags (#2279)
  Add Sync Success Rate pixel  (#2277)
  add test 5 and fix test 4 (#2276)
  Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274)
  Send WG invalid state reason (#2275)
  Typo
  Fix: "SwiftLintPlugin" must be enabled before it can be used
  Release 7.102.0 (#2273)
  Add search retention pixel for NetP (#2267)
  Run sync tests in matrix (#2263)
  SwiftLint build plugin (#2233)
  Update VPN active user check and debug options (#2269)
  Update Autofill Logins copy (#2246)
  Remove the reconnect/disconnect logic from the connection tester (#2272)
  Remove the Fastlane notes file temporarily (#2270)
  remove QR code from save recovery PDF view (#2271)
  Show dev environment indicator in Sync Settings (#2265)
  Release 7.101.0.1 (#2262)
  Sync Flow Error Handling (#2264)
  Fix fingerprinting UI tests (#2252)
  ...
samsymons added a commit that referenced this pull request Dec 22, 2023
# By Sam Symons (13) and others
# Via Bartek Waresiak (2) and others
* main: (69 commits)
  Custom config URL (#2278)
  Fix internal user toggling (#2282)
  Display warning icon in Sync Settings cell when data syncing is disabled (#2281)
  Add Sync feature flags (#2279)
  Add Sync Success Rate pixel  (#2277)
  add test 5 and fix test 4 (#2276)
  Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274)
  Send WG invalid state reason (#2275)
  Typo
  Fix: "SwiftLintPlugin" must be enabled before it can be used
  Release 7.102.0 (#2273)
  Add search retention pixel for NetP (#2267)
  Run sync tests in matrix (#2263)
  SwiftLint build plugin (#2233)
  Update VPN active user check and debug options (#2269)
  Update Autofill Logins copy (#2246)
  Remove the reconnect/disconnect logic from the connection tester (#2272)
  Remove the Fastlane notes file temporarily (#2270)
  remove QR code from save recovery PDF view (#2271)
  Show dev environment indicator in Sync Settings (#2265)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants