Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom config URL #2278

Merged
merged 18 commits into from
Dec 21, 2023
Merged

Custom config URL #2278

merged 18 commits into from
Dec 21, 2023

Conversation

jaceklyp
Copy link
Contributor

@jaceklyp jaceklyp commented Dec 19, 2023

Task/Issue URL: https://app.asana.com/0/72649045549333/1205661297103826/f

Description:

Enable custom configuration url debugging.

Copy link

github-actions bot commented Dec 19, 2023

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 37935bb

Comment on lines 462 to 463
<color red="0.20392156859999999" green="0.78039215689999997" blue="0.34901960780000002" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
<color red="0.20392156862745098" green="0.7803921568627451" blue="0.34901960784313724" alpha="1" colorSpace="custom" customColorSpace="sRGB"/>
</systemColor>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably unwanted change.

Comment on lines -579 to 580
<rect key="frame" x="0.0" y="0.0" width="355.66666666666669" height="43.666667938232422"/>
<rect key="frame" x="0.0" y="0.0" width="343.66666666666669" height="43.666667938232422"/>
<autoresizingMask key="autoresizingMask"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, no meaningful changed in this file.

@jaceklyp jaceklyp merged commit 6dd32f6 into main Dec 21, 2023
9 of 10 checks passed
@jaceklyp jaceklyp deleted the jacek/custom-config-url branch December 21, 2023 18:32
samsymons added a commit that referenced this pull request Dec 22, 2023
# By Sam Symons (13) and others
# Via Bartek Waresiak (2) and others
* main: (69 commits)
  Custom config URL (#2278)
  Fix internal user toggling (#2282)
  Display warning icon in Sync Settings cell when data syncing is disabled (#2281)
  Add Sync feature flags (#2279)
  Add Sync Success Rate pixel  (#2277)
  add test 5 and fix test 4 (#2276)
  Fix: "SwiftLintPlugin" must be enabled before it can be used (#2274)
  Send WG invalid state reason (#2275)
  Typo
  Fix: "SwiftLintPlugin" must be enabled before it can be used
  Release 7.102.0 (#2273)
  Add search retention pixel for NetP (#2267)
  Run sync tests in matrix (#2263)
  SwiftLint build plugin (#2233)
  Update VPN active user check and debug options (#2269)
  Update Autofill Logins copy (#2246)
  Remove the reconnect/disconnect logic from the connection tester (#2272)
  Remove the Fastlane notes file temporarily (#2270)
  remove QR code from save recovery PDF view (#2271)
  Show dev environment indicator in Sync Settings (#2265)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Dec 22, 2023
* main:
  Update Link Tracking Protection to preserve headers (#2268)
  Custom config URL (#2278)
  Fix internal user toggling (#2282)
  Display warning icon in Sync Settings cell when data syncing is disabled (#2281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants