Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report CancellationError from BookmarksFaviconsFetcher #2385

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jan 25, 2024

Task/Issue URL: https://app.asana.com/0/1201493110486074/1206407973669779/f
Tech Design URL:
CC:

Description:
Keep cancelling operations when requested, but without reporting the cancellation
to errorEvents, which could have caused them being reported as Pixels.

Steps to test this PR:
See BSK

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Jan 25, 2024
@ayoy ayoy requested a review from SabrinaTardio January 25, 2024 12:22
@ayoy ayoy assigned SabrinaTardio and unassigned ayoy Jan 25, 2024
@ayoy ayoy marked this pull request as ready for review January 25, 2024 12:22
@ayoy ayoy merged commit 7c96384 into main Jan 26, 2024
10 checks passed
@ayoy ayoy deleted the dominik/favicons-fetcher-cancellation-error branch January 26, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants